Skip to content

[GLUEN-10107][INFRA]Deprecate isUseUniffleShuffleManager from glutenConfig #10558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Sep 1, 2025
Merged

[GLUEN-10107][INFRA]Deprecate isUseUniffleShuffleManager from glutenConfig #10558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions ...ickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHSparkPlanExecApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,15 +462,11 @@ class CHSparkPlanExecApi extends SparkPlanExecApi with Logging {
clazz.getConstructor(classOf[SQLMetric], classOf[SQLMetric], classOf[SQLMetric])
constructor.newInstance(readBatchNumRows, numOutputRows, dataSize).asInstanceOf[Serializer]
case _ =>
if (GlutenConfig.get.isUseUniffleShuffleManager) {
throw new UnsupportedOperationException("temporarily uniffle not support ch ")
} else {
new CHColumnarBatchSerializer(
readBatchNumRows,
numOutputRows,
dataSize,
deserializationTime)
}
new CHColumnarBatchSerializer(
readBatchNumRows,
numOutputRows,
dataSize,
deserializationTime)
}
}

Expand Down
2 changes: 1 addition & 1 deletion gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ class GlutenConfig(conf: SQLConf) extends GlutenCoreConfig(conf) {
.contains("celeborn")

// Whether to use UniffleShuffleManager.
// TODO: Deprecate the API: https://github.com/apache/incubator-gluten/issues/10107.
@deprecated
def isUseUniffleShuffleManager: Boolean =
conf
.getConfString("spark.shuffle.manager", "sort")
Expand Down