[FLINK] Add java-17 profile for Flink build and update project version in flink doc#10561
[FLINK] Add java-17 profile for Flink build and update project version in flink doc#10561philo-he merged 2 commits intoapache:mainfrom
java-17 profile for Flink build and update project version in flink doc#10561Conversation
|
@zjuwangg, It makes sense to fix this since both Java 11 and 17 are supported. Setting maven.compiler.source/target to 17 would cause compatibility issues when building Gluten Flink with Java 11. I think we can add a profile named java-17 to set both properties to 17 (defaults to 11) if users want to build the code with Java 17. This approach is different from setting the compiler properties to 11 while building with Java 17, as it enables Java 17 features. As you mentioned, velox4j is compiled with Java 11, but it should work when running on a Java 17 JVM due to Java's backward compatibility. Therefore, I assume we don't need to hardcode the compiler source and target properties to 11. |
@philo-he |
|
@philo-he Just add a java-17 compile profile. |
philo-he
left a comment
There was a problem hiding this comment.
Looks good. Could you enable this profile in Flink CI job? I note Java 17 is used. Please also update the build section in Flink.md to indicate that users should add -Pjava-17 when building with Java 17.
Since we add jdk 17 activation option, java-17 profile will be auto selected when build with java 17. Tested passed in my owne box. |
I'll investigate on this and enable this profile in another separate PR. |
|
@zjuwangg, I see. Then, there is no need to explicitly add the option in Flink CI. Thanks. |
java-17 profile for Flink build and update flink doc to match version
java-17 profile for Flink build and update flink doc to match versionjava-17 profile for Flink build and update project version in flink doc
What changes are proposed in this pull request?
#10515 has made a great effort to decouple flink from parent gluten.
This PR adds a profile named java-17 to set both
maven.compiler.source/targetto 17 (defaults to 11) if users want to build the code with Java 17.This PR update compiler version and update build jar version to match the master pom version change.
How was this patch tested?
NA