[GLUTEN-10570][FLINK] Add --add-opens options to MAVEN_OPTS for Java 17 compatibility

[KevinyhZou]

What changes are proposed in this pull request?

fix flink ut failure on jdk17, related issue: #10570

How was this patch tested?

UT

[github-actions]

#10570

[philo-he]

Flink CI is using JDK 17. I'm curious why this issue is not reported by CI.

[jinchengchenghh]

Maybe you also need, otherwise you may meet exception in the future, not sure for that.

      '--add-opens=java.base/java.lang=ALL-UNNAMED' \
      '--add-opens=java.base/java.lang.invoke=ALL-UNNAMED' \
      '--add-opens=java.base/java.lang.reflect=ALL-UNNAMED' \
      '--add-opens=java.base/java.io=ALL-UNNAMED' \
      '--add-opens=java.base/java.net=ALL-UNNAMED' \
      '--add-opens=java.base/java.nio=ALL-UNNAMED' \
      '--add-opens=java.base/java.util=ALL-UNNAMED' \
      '--add-opens=java.base/java.util.concurrent=ALL-UNNAMED' \
      '--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED' \
      '--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED' \
      '--add-opens=java.base/sun.nio.ch=ALL-UNNAMED' \
      '--add-opens=java.base/sun.nio.cs=ALL-UNNAMED' \
      '--add-opens=java.base/sun.security.action=ALL-UNNAMED' \
      '--add-opens=java.base/sun.util.calendar=ALL-UNNAMED' \

[philo-he]

@jinchengchenghh, I just became aware of this. The current Flink CI has already added some Maven arguments (including the proposed args of this PR) that ensure compilation and tests pass on JDK 17. See the link below.

@KevinyhZou, could you help confirm whether these remaining arguments also need to be added? @jinchengchenghh has provided a more comprehensive list, some of which are not necessary now but may become necessary in the future. Perhaps we should also consider adding these.

https://github.com/apache/incubator-gluten/blob/05c8703dd3473f4008bbc0196a7b083cc032ee17/.github/workflows/flink.yml#L25-L29

[KevinyhZou]

@jinchengchenghh, I just became aware of this. The current Flink CI has already added some Maven arguments (including the proposed args of this PR) that ensure compilation and tests pass on JDK 17. See the link below.

@KevinyhZou, could you help confirm whether these remaining arguments also need to be added? @jinchengchenghh has provided a more comprehensive list, some of which are not necessary now but may become necessary in the future. Perhaps we should also consider adding these.

https://github.com/apache/incubator-gluten/blob/05c8703dd3473f4008bbc0196a7b083cc032ee17/.github/workflows/flink.yml#L25-L29

As java17 is still a experimental feature on flink-1.19: https://nightlies.apache.org/flink/flink-docs-release-1.19/docs/deployment/java_compatibility/#java-17, I think we'd better add these options to avoid the incompatibility on flink，or we should use jdk11 @philo-he

[jinchengchenghh]

I think @philo-he means adding all of possible options in https://github.com/apache/incubator-gluten/blob/05c8703dd3473f4008bbc0196a7b083cc032ee17/.github/workflows/flink.yml#L25-L29

[KevinyhZou]

I have added some possible options in flink.yml, please help to review it. @philo-he @jinchengchenghh

[philo-he]

@KevinyhZou, thanks for your update. Do we need to add these args in gluten-flink/ut/pom.xml, similar to the following? Assume they are required for developers to run mvn test with Java 17 in the local.

https://github.com/apache/incubator-gluten/blob/7f5fb2d8a98d1410072858244235363530868593/pom.xml#L1622

[KevinyhZou]

@KevinyhZou, thanks for your update. Do we need to add these args in gluten-flink/ut/pom.xml, similar to the following? Assume they are required for developers to run mvn test with Java 17 in the local.

https://github.com/apache/incubator-gluten/blob/7f5fb2d8a98d1410072858244235363530868593/pom.xml#L1622

done

[philo-he]

Thanks.