[GLUTEN-10577][CELEBORN] Refactor CelebornShuffleManager to load factory in a better way#10591
Merged
philo-he merged 5 commits intoapache:mainfrom Sep 4, 2025
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
zjuwangg
changed the title
|
Run Gluten Clickhouse CI on x86 |
zjuwangg
changed the title
philo-he
changed the title
CelebornShuffleManager to load factory in a better way
Contributor
Author
|
@philo-he would like to help review this PR? Thanks a lot |
philo-he
reviewed
Sep 3, 2025
|
Run Gluten Clickhouse CI on x86 |
philo-he
reviewed
Sep 3, 2025
|
Run Gluten Clickhouse CI on x86 |
philo-he
approved these changes
Sep 4, 2025
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Looks good. Two minor comments.
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Refactor CelebornShuffleManager use list instead of map to load the factory as described in #10577 .
How was this patch tested?
Existing tests.