[GLUTEN-10605][VL] Rewrite unbounded window to an equivalent aggregate join#10606
Merged
zml1206 merged 2 commits intoapache:mainfrom Sep 5, 2025
Merged
[GLUTEN-10605][VL] Rewrite unbounded window to an equivalent aggregate join#10606zml1206 merged 2 commits intoapache:mainfrom
zml1206 merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@JkSelf What do you think of this feature? It should make up for some of the current shortcomings of Velox Window. |
JkSelf
approved these changes
Sep 4, 2025
Contributor
JkSelf
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your improving.
Contributor
Author
|
@JkSelf Thanks for review, merge into main. |
wForget
pushed a commit
to wForget/gluten
that referenced
this pull request
Sep 23, 2025
…e join (apache#10606) (cherry picked from commit 84ac418)
Closed
wForget
added a commit
to wForget/gluten
that referenced
this pull request
Sep 23, 2025
…aggregate join (apache#10606)" This reverts commit 17755bf.
wForget
pushed a commit
to wForget/gluten
that referenced
this pull request
Oct 15, 2025
…e join (apache#10606) (cherry picked from commit 84ac418)
zml1206
added a commit
to zml1206/gluten
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
For unbounded window, velox needs to load the entire partition's data into memory for calculation, which can easily cause OOM when the partition is too large. This rule rewrites unbounded window to an equivalent aggregate join operation to avoid OOM.
Input query:
Rewritten query:
How was this patch tested?
UT