Skip to content

[Minor] Add enhanced features runtime config #10608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinchengchenghh merged 1 commit into from
Sep 3, 2025
Merged

[Minor] Add enhanced features runtime config #10608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ object VeloxBackendSettings extends BackendSettingsApi {

override def reorderColumnsForPartitionWrite(): Boolean = true

override def enableEnhancedFeatures(): Boolean = VeloxConfig.enableEnhancedFeatures()
override def enableEnhancedFeatures(): Boolean = VeloxConfig.get.enableEnhancedFeatures()

override def supportAppendDataExec(): Boolean =
GlutenConfig.get.enableAppendData && enableEnhancedFeatures()
Expand Down
11 changes: 9 additions & 2 deletions backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,13 @@ class VeloxConfig(conf: SQLConf) extends GlutenConfig(conf) {

def enableRewriteCastArrayToString: Boolean =
getConf(ENABLE_REWRITE_CAST_ARRAY_TO_STRING)

def enableEnhancedFeatures(): Boolean = ConfigJniWrapper.isEnhancedFeaturesEnabled &&
getConf(ENABLE_ENHANCED_FEATURES)
}

object VeloxConfig {

def enableEnhancedFeatures(): Boolean = ConfigJniWrapper.isEnhancedFeaturesEnabled

def get: VeloxConfig = {
new VeloxConfig(SQLConf.get)
}
Expand Down Expand Up @@ -685,4 +686,10 @@ object VeloxConfig {
" `concat('[', array_join(array, ', ', null), ']')` to allow offloading to Velox.")
.booleanConf
.createWithDefault(true)

val ENABLE_ENHANCED_FEATURES =
buildConf("spark.gluten.sql.enable.enhancedFeatures")
.doc("Enable some features including iceberg native write and other features.")
.booleanConf
.createWithDefault(true)
}