[GLUTEN-10635][VL] bugfix: file INSTALL cannot set permissions#10638
[GLUTEN-10635][VL] bugfix: file INSTALL cannot set permissions#10638philo-he merged 3 commits intoapache:mainfrom
Conversation
|
I actually encountered this problem when running if [[ "$(uname)" == "Darwin" ]]; then
INSTALL_PREFIX=${INSTALL_PREFIX:-${VELOX_HOME}/deps-install}
else
INSTALL_PREFIX=${INSTALL_PREFIX:-"/usr/local"}
fiMaybe we need a fix? @zhouyuan |
|
@Zouxxyy, MacOS was not properly considered in the Arrow installation. You can propose a fix to use a path more suitable for MacOS. Maybe, you can just replace |
dev/build_helper_functions.sh
Outdated
| cmake --build "${BINARY_DIR}" | ||
| if [ -z "${SUDO}" ]; then | ||
| if command -v sudo >/dev/null 2>&1 && sudo -n true 2>/dev/null; then | ||
| SUDO="sudo" |
There was a problem hiding this comment.
Can we just let user fix this issue by setting SUDO=sudo in the environment?
There was a problem hiding this comment.
Thank you! I tried in this way. But it is still not working.
There was a problem hiding this comment.
Can you pease try to add this line in the beginning of this file?
https://github.com/apache/incubator-gluten/blob/main/dev/build_arrow.sh#L21
There was a problem hiding this comment.
It seems line 21 should be changed to SUDO="${SUDO:-""}", where all letters are capitalized. Then, I assume setting SUDO=sudo in the environment should work.
There was a problem hiding this comment.
It seems line 21 should be changed to
SUDO="${SUDO:-""}", where all letters are capitalized. Then, I assume settingSUDO=sudoin the environment should work.
I tried this way, it works well. But I don't know if it will affect other OS.
There was a problem hiding this comment.
@beliefer, I suggest to just fix this line, and let users explicitly set the environment variable if they meet such permission issue.
4 participants
What changes are proposed in this pull request?
This PR proposes to fix a building bug.
Fixes #10635
How was this patch tested?
GA tests.