Skip to content

[GLUTEN-11678][VL] Native validation should check CrossRelNode's expression#11679

Merged
jinchengchenghh merged 5 commits intoapache:mainfrom
wecharyu:validate_cross_expression
Apr 3, 2026
Merged

[GLUTEN-11678][VL] Native validation should check CrossRelNode's expression#11679
jinchengchenghh merged 5 commits intoapache:mainfrom
wecharyu:validate_cross_expression

Conversation

@wecharyu
Copy link
Copy Markdown
Contributor

@wecharyu wecharyu commented Mar 2, 2026

What changes are proposed in this pull request?

Check the CrossRelNode's expression, fallback it if experssion is not supported.
Fix #11678.

How was this patch tested?

Add unit test.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the VELOX label Mar 2, 2026
@jinchengchenghh
Copy link
Copy Markdown
Contributor

Please resolve the failed test

- get correct fallback reason on nodes without logicalLink
- fallback when nested loop join has unsupported expression *** FAILED ***
  fallbackReasons.forall(((x$6: String) => x$6.contains("regexp_extract due to Pattern (?<="))) was false (FallbackSuite.scala:392)
11:23:43.481 WARN org.apache.gluten.execution.FallbackSuite: 

@wecharyu wecharyu force-pushed the validate_cross_expression branch from 95af245 to 63d06a2 Compare March 5, 2026 02:43
@wecharyu
Copy link
Copy Markdown
Contributor Author

wecharyu commented Mar 5, 2026

Addressed failed test, please take a look again. @jinchengchenghh

@wecharyu
Copy link
Copy Markdown
Contributor Author

wecharyu commented Apr 1, 2026

Gentle ping @jinchengchenghh, if no more concerns could you help merge it? Thanks!

@jinchengchenghh
Copy link
Copy Markdown
Contributor

Please rebase to latest main and solve the failed compiler

@wecharyu wecharyu force-pushed the validate_cross_expression branch from 80b9124 to 00d3508 Compare April 1, 2026 15:08
@wecharyu
Copy link
Copy Markdown
Contributor Author

wecharyu commented Apr 3, 2026

Rebased and CI is green. @jinchengchenghh please take a look.

@jinchengchenghh jinchengchenghh merged commit b64cd7b into apache:main Apr 3, 2026
59 checks passed
@jinchengchenghh
Copy link
Copy Markdown
Contributor

Thanks!

malinjawi pushed a commit to malinjawi/incubator-gluten that referenced this pull request Apr 9, 2026
…ession (apache#11679)

Check the CrossRelNode's expression, fallback it if experssion is not supported.
Fix apache#11678.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VL] CrossRelNode's expression is not validated in native validation

2 participants