Skip to content

[GJ-41] Support WS Tansformer with row-based output#42

Merged
rui-mo merged 1 commit intoapache:masterfrom
zzcclp:support_clickhouse
Jan 20, 2022
Merged

[GJ-41] Support WS Tansformer with row-based output#42
rui-mo merged 1 commit intoapache:masterfrom
zzcclp:support_clickhouse

Conversation

@zzcclp
Copy link
Copy Markdown
Contributor

@zzcclp zzcclp commented Jan 19, 2022

  1. Support ClickHouse as native engine;
  2. Support Row iterator;
  3. Add config 'spark.oap.sql.columnar.iterator' to specify whether to use columnar basic iterator

Following PR:

  1. JNI Interface
  2. Optimise Code

Closes #41.

@zzcclp zzcclp requested a review from rui-mo January 19, 2022 09:41
Comment thread jvm/src/main/java/com/intel/oap/vectorized/CHJniInstance.java
@zzcclp zzcclp force-pushed the support_clickhouse branch from 7f0b87f to e2db235 Compare January 20, 2022 02:55
@zzcclp zzcclp force-pushed the support_clickhouse branch from e2db235 to b3c17af Compare January 20, 2022 06:22
@rui-mo
Copy link
Copy Markdown
Contributor

rui-mo commented Jan 20, 2022

This option spark.oap.sql.columnar.iterator and related logic are expected to be removed after Kyligence transfer to columnar computing.

Copy link
Copy Markdown
Contributor

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rui-mo
Copy link
Copy Markdown
Contributor

rui-mo commented Jan 20, 2022

Verified this PR on both master and Velox branches.

@rui-mo rui-mo changed the title [GJ-41] Support ClickHouse as native engine [GJ-41] Support WS Tansformer with row-based output Jan 20, 2022
@rui-mo rui-mo merged commit 6d7fe2c into apache:master Jan 20, 2022
rui-mo pushed a commit to rui-mo/gazelle-jni that referenced this pull request Jan 20, 2022
@zzcclp zzcclp deleted the support_clickhouse branch July 21, 2022 01:57
KevinyhZou pushed a commit to KevinyhZou/gluten that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support WS Tansformer with row-based output

2 participants