[VL] New option to follow vanilla Spark's build side in shuffled hash join#7133
Merged
kecookier merged 2 commits intoapache:mainfrom Sep 6, 2024
Merged
[VL] New option to follow vanilla Spark's build side in shuffled hash join#7133kecookier merged 2 commits intoapache:mainfrom
kecookier merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI |
Member
Author
Contributor
|
It looks good to me. Thanks! |
kecookier
approved these changes
Sep 6, 2024
dcoliversun
pushed a commit
to dcoliversun/gluten
that referenced
this pull request
Sep 11, 2024
… join (apache#7133) * [VL] New option to follow vanilla Spark's build side in shuffled hash join * fixup
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
… join (apache#7133) * [VL] New option to follow vanilla Spark's build side in shuffled hash join * fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's observed the new way to choose smaller side of shuffled hash join as build side, introduced in #6093, could cause performance regression comparing to elder versions of Gluten because of inaccurate statistic calculations.
The PR provides an option
spark.gluten.sql.columnar.shuffledHashJoin.optimizeBuildSidewhich can be set tofalseto keep using vanilla Spark's build side in Gluten's shuffled hash join.