[GLUTEN-7977][VL] Include cstdint header explicitly#8030
Merged
philo-he merged 4 commits intoapache:mainfrom Nov 27, 2024
Merged
[GLUTEN-7977][VL] Include cstdint header explicitly#8030philo-he merged 4 commits intoapache:mainfrom
philo-he merged 4 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
yabinma
changed the title
yabinma
changed the title
Member
|
@yabinma, thanks for your pr! Please fix code style issue reported by clang-format. |
Contributor
Author
|
The Velox build error should not be caused by the code change here. I merged the latest code base and let's run it again. Thanks. |
philo-he
approved these changes
Nov 27, 2024
philo-he
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add cstdint include explicitly for avoiding compile error with gcc 13.2 on Ubunut 24.04
(Fixes: #7977)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Manual test passed
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)