[GLUTEN-7914][CORE] Flip dependency direction for gluten-celeborn#8241
Merged
zhztheplayer merged 2 commits intoapache:mainfrom Dec 17, 2024
Merged
[GLUTEN-7914][CORE] Flip dependency direction for gluten-celeborn#8241zhztheplayer merged 2 commits intoapache:mainfrom
zhztheplayer merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
927a2a1 to
7ad7ce1
Compare
|
Run Gluten Clickhouse CI on x86 |
rui-mo
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7914
Make Maven module backends-velox depend on gluten-celeborn than the opposite, to make sure the common source code and UT code (particularly celebornSuite at the moment) to be accessible from other backend modules.
The new folder backends-velox/src-celeborn is added for placing code that relate to Velox+celeborn support.
TODO in subsequent PRs:
Enable Maven code linters for backends-velox/src-celeborn