[GLUTEN-8397][CH][Part-1]: Disable hdfs while compiling clickhouse backend on macOS#8400
Merged
baibaichen merged 3 commits intoapache:mainfrom Jan 6, 2025
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
lwz9103
reviewed
Jan 6, 2025
cpp-ch/local-engine/CMakeLists.txt
Outdated
| set(CMAKE_SHARED_LINKER_FLAGS | ||
| "${CMAKE_EXE_LINKER_FLAGS} -Wl,--no-export-dynamic -Wl,--gc-sections") | ||
|
|
||
| if (LINUX) |
lwz9103
reviewed
Jan 6, 2025
cpp-ch/local-engine/CMakeLists.txt
Outdated
| target_link_options( | ||
| ${LOCALENGINE_SHARED_LIB} PRIVATE | ||
| -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/libch-hide-jemalloc.map) | ||
| if(LINUX) |
yxheartipp
force-pushed
the
mac-cross-compile
branch
from
13a4127 to
f818326
Compare
|
Run Gluten Clickhouse CI on x86 |
Member
|
@baibaichen Can you help to review this PR? |
baibaichen
changed the title
3 tasks
baibaichen
reviewed
Jan 6, 2025
|
|
||
| auto * addresses = env->NewLongArray(bs.block_addresses.size()); | ||
| env->SetLongArrayRegion(addresses, 0, bs.block_addresses.size(), bs.block_addresses.data()); | ||
| env->SetLongArrayRegion(addresses, 0, bs.block_addresses.size(), (const jlong *)bs.block_addresses.data()); |
Contributor
There was a problem hiding this comment.
may be reinterpret_cast
let's use static_cast first for safety
| auto * offsets_arr = env->NewLongArray(spark_row_info.getNumRows()); | ||
| const auto * offsets_src = spark_row_info.getOffsets().data(); | ||
| env->SetLongArrayRegion(offsets_arr, 0, spark_row_info.getNumRows(), offsets_src); | ||
| env->SetLongArrayRegion(offsets_arr, 0, spark_row_info.getNumRows(), (const jlong *)offsets_src); |
taiyang-li
reviewed
Jan 6, 2025
| // Increase the speed of metadata recovery | ||
| auto max_concurrency = std::max(10UL, QueryContext::globalContext()->getSettingsRef()[Setting::max_threads].value); | ||
| auto max_threads = std::min(max_concurrency, not_exists_part.size()); | ||
| auto max_concurrency = std::max(static_cast<UInt64>(10UL), QueryContext::globalContext()->getSettingsRef()[Setting::max_threads].value); |
|
Run Gluten Clickhouse CI on x86 |
yxheartipp
force-pushed
the
mac-cross-compile
branch
from
1a5d69a to
85c7364
Compare
|
Run Gluten Clickhouse CI on x86 |
yxheartipp
force-pushed
the
mac-cross-compile
branch
from
85c7364 to
4331829
Compare
|
Run Gluten Clickhouse CI on x86 |
baibaichen
approved these changes
Jan 6, 2025
yxheartipp
force-pushed
the
mac-cross-compile
branch
from
4331829 to
dd0f4ad
Compare
|
Run Gluten Clickhouse CI on x86 |
yxheartipp
force-pushed
the
mac-cross-compile
branch
from
dd0f4ad to
7cb1111
Compare
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
mac-cross-compile
branch
from
7cb1111 to
72fc378
Compare
|
Run Gluten Clickhouse CI on x86 |
yxheartipp
force-pushed
the
mac-cross-compile
branch
from
72fc378 to
6c4dd15
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8397
Disable hdfs while compiling clickhouse backend on macOS.
There will be no change for origin tests.