[GLUTEN-8414][VL] Override doCanonicalize in ColumnarPartialProjectEx…#8415
Merged
zhztheplayer merged 4 commits intoapache:mainfrom Jan 9, 2025
Merged
Conversation
Contributor
|
Thank you for your first PR! |
Member
|
Thanks for the contribution in advance. I am also curious why |
Contributor
|
Because the class |
773fa10 to
54d0a6f
Compare
Contributor
Author
|
@zhztheplayer @jinchengchenghh hello, is this pr ready for merging ? |
zml1206
pushed a commit
to zml1206/gluten
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ec node
What changes were proposed in this pull request?
implement doCanonicalize in ColumnarPartialProjectExec node, for reuse exchange contains ColumnarPartialProjectExec
(same kind problem as #3154)
(Fixes: #8414)
How was this patch tested?
manual test in our product env
the biggest table read four times before implement doCanonicalize in ColumnarPartialProjectExec
the biggest table read one times before implement doCanonicalize in ColumnarPartialProjectExec
we can also see the stage reuse multi times after implement doCanonicalize in ColumnarPartialProjectExec in spark plan