Skip to content

[DOC] Update README.md#8444

Merged
philo-he merged 5 commits intoapache:mainfrom
philo-he:update-doc
Jan 13, 2025
Merged

[DOC] Update README.md#8444
philo-he merged 5 commits intoapache:mainfrom
philo-he:update-doc

Conversation

@philo-he
Copy link
Copy Markdown
Member

@philo-he philo-he commented Jan 7, 2025

  • Add ASF slack channel.
  • Add two companies that contributed to the development.
  • Rephrase the statement.
  • Remove unnecessary part and remove repetition.

@github-actions github-actions bot added the DOCS label Jan 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Comment thread README.md Outdated
### 3.2.1 Build and install Gluten with Velox backend
There are two ways to acquire Gluten jar.

# 3.1 Use Released Jar (only applicable to Velox backend)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 "currently only applicable to Velox backend"

Comment thread README.md
# 3.1 Use Released Jar (only applicable to Velox backend)

If you want to use Gluten **Velox** backend, see [Build with Velox](./docs/get-started/Velox.md) to build and install the necessary libraries.
Please download a tar package [here](https://downloads.apache.org/incubator/gluten/), then extract out Gluten jar from it.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the jar build staticly? can the jar be used on any OS? I don't think so. If so let's put the OS where the jar is built.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FelixYBW, just confirmed with Weiting. The published release jar was generated by static build.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even it's static built, it can still be used on the OS where it's built. Because it still depends on libc etc. which is different in different OS. We need to put the OSes we confirmed it can run on.

Comment thread README.md Outdated
@@ -63,58 +66,42 @@ There are several key components in Gluten:

# 3 How to Use
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it as "User Guide"

Comment thread README.md
# 3 How to Use

There are two ways to use Gluten.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the supported Spark versions (including minor version) and OS. Highlight that with static build we support all the OS types.

Comment thread README.md Outdated
# 7 Acknowledgements

# 8 Thanks to our contributors
Gluten was initiated by Intel and Kyligence in 2022. Several companies are also actively participating in the development, such as BIGO, Meituan, Alibaba Cloud, NetEase, Baidu, Microsoft, etc.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add IBM here.

@srinivasst would like to add "Google" here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Comment thread README.md Outdated
## 4.1 Community

Gluten successfully joined Apache Incubator since March'24. We welcome developers and users who are interested in Gluten project. Here are several ways to contact us:
Gluten successfully became Apache incubator project in March'24. We welcome all developers and users who are interested in this project. Here are several ways to contact us:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the community mail list here:

* For community activity: dev@gluten.apache.org
* For code repository activity: commits@gluten.apache.org

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore it. Just noted the mailing lists section below

@FelixYBW
Copy link
Copy Markdown
Contributor

FelixYBW commented Jan 8, 2025

@philo-he can you add the slack channel as well?

ASF workspace invite link (https://join.slack.com/t/the-asf/shared_invite/zt-2x74bfj6u-_3mH6Njlq6lZoIAZKNsutw))

Then search "incubator-gluten“ channel

@zhztheplayer
Copy link
Copy Markdown
Member

zhztheplayer commented Jan 9, 2025

@philo-he can you add the slack channel as well?

ASF workspace invite link (https://join.slack.com/t/the-asf/shared_invite/zt-2x74bfj6u-_3mH6Njlq6lZoIAZKNsutw))

Then search "incubator-gluten“ channel

For the slack channels (as well as other chat rooms), I recommend to lower the importance of them when users request for a way to ask questions or discuss about issues. Could encourage them to use GitHub or Apache mailing list more since they are more public and can be indexed by search engines. Do you guys have related thoughts?

cc @zhouyuan @weiting-chen

@FelixYBW
Copy link
Copy Markdown
Contributor

FelixYBW commented Jan 9, 2025

@philo-he can you add the slack channel as well?
ASF workspace invite link (join.slack.com/t/the-asf/shared_invite/zt-2x74bfj6u-_3mH6Njlq6lZoIAZKNsutw))
Then search "incubator-gluten“ channel

For the slack channels (as well as other chat rooms), I recommend to lower the importance of them when users request for a way to ask questions or discuss about issues. Could encourage them to use GitHub or Apache mailing list more since they are more public and can be indexed by search engines. Do you guys have related thoughts?

cc @zhouyuan @weiting-chen

They are complementary each other, not replace each other. Let's put the link on home page

@zhztheplayer
Copy link
Copy Markdown
Member

zhztheplayer commented Jan 9, 2025

@philo-he can you add the slack channel as well?
ASF workspace invite link (join.slack.com/t/the-asf/shared_invite/zt-2x74bfj6u-_3mH6Njlq6lZoIAZKNsutw))
Then search "incubator-gluten“ channel

For the slack channels (as well as other chat rooms), I recommend to lower the importance of them when users request for a way to ask questions or discuss about issues. Could encourage them to use GitHub or Apache mailing list more since they are more public and can be indexed by search engines. Do you guys have related thoughts?
cc @zhouyuan @weiting-chen

They are complementary each other, not replace each other. Let's put the link on home page

I will be fine with adding a Slack link to documentation, since Slack's still open to all users so worth try with. Do you think we can add a note around the link to remind user that use of GitHub and Apache mailing list is encouraged?

E.g.,

* Slack channel: join.slack.com/...
  Note: Slack channel should only be used for informal chats. It's encouraged to use GitHub / Mailing list for raising issues or technical discussions.

@FelixYBW
Copy link
Copy Markdown
Contributor

FelixYBW commented Jan 9, 2025

I will be fine with adding a Slack link to documentation, since Slack's still open to all users so worth try with. Do you think we can add a note around the link to remind user that use of GitHub and Apache mailing list is encouraged?

We needn't. We should encourage user use github issues instead of mailing. Many companies use Slack more than mails now.

@philo-he philo-he force-pushed the update-doc branch 2 times, most recently from 0df443e to 0a4e6fa Compare January 10, 2025 06:06
@philo-he philo-he marked this pull request as ready for review January 10, 2025 06:26
@philo-he philo-he changed the title [DOC] Update document [DOC] Update README.md Jan 10, 2025
@philo-he
Copy link
Copy Markdown
Member Author

@FelixYBW, @zhztheplayer, if you have any other comment, please let me know.

@FelixYBW
Copy link
Copy Markdown
Contributor

Looks good. @baibaichen @zzcclp Would you take a look?

Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@philo-he philo-he merged commit adf092d into apache:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants