[GLUTEN-8479][CORE][Part-1] Remove unnecessary config#8480
Merged
jackylee-ch merged 2 commits intoapache:mainfrom Jan 15, 2025
Merged
[GLUTEN-8479][CORE][Part-1] Remove unnecessary config#8480jackylee-ch merged 2 commits intoapache:mainfrom
jackylee-ch merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten ClickHouse CI on ARM |
7 tasks
Contributor
Author
|
@jackylee-ch @baibaichen Could you please take a look, thanks! |
|
Run Gluten ClickHouse CI on ARM |
1 similar comment
|
Run Gluten ClickHouse CI on ARM |
yikf
force-pushed
the
unnecessary-config
branch
from
8e3c174 to
a1bc64a
Compare
|
Run Gluten ClickHouse CI on ARM |
yikf
force-pushed
the
unnecessary-config
branch
from
a1bc64a to
c28ccef
Compare
|
Run Gluten ClickHouse CI on ARM |
1 similar comment
|
Run Gluten ClickHouse CI on ARM |
Contributor
|
please add the removed configs in PR description. |
Contributor
Author
added, thanks! |
|
Run Gluten ClickHouse CI on ARM |
Yohahaha
approved these changes
Jan 13, 2025
Contributor
Yohahaha
left a comment
Yohahaha
left a comment
There was a problem hiding this comment.
LGTM! left one comment.
yikf
force-pushed
the
unnecessary-config
branch
from
533132b to
65543fc
Compare
|
Run Gluten ClickHouse CI on ARM |
jackylee-ch
approved these changes
Jan 14, 2025
|
Run Gluten ClickHouse CI on ARM |
Contributor
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
approved these changes
Jan 15, 2025
| .config("spark.databricks.delta.snapshotPartitions", 1) | ||
| .config("spark.databricks.delta.properties.defaults.checkpointInterval", 5) | ||
| .config("spark.databricks.delta.stalenessLimit", 3600 * 1000) | ||
| .config("spark.gluten.sql.columnar.columnarToRow", columnarColumnToRow) |
Member
There was a problem hiding this comment.
nit: Could remove the variable definition if unused?
Contributor
There was a problem hiding this comment.
They has be removed in this pr. see GlutenConfig change
Contributor
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix #8479, This PR removed some unused configurations and methods for getting configurations. The removed configurations are as follows:
How was this patch tested?
GA.