[GLUTEN-8520][VL] Fix bitwise operators#8521
Merged
FelixYBW merged 1 commit intoapache:mainfrom Jan 15, 2025
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
6146892 to
7c82887
Compare
7c82887 to
b3db3dc
Compare
b3db3dc to
74bf1a1
Compare
FelixYBW
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use bitwise operators only on unsigned operands
False positives
cpp/velox/tests/MemoryManagerTest.cc:43
cpp/velox/benchmarks/ColumnarToRowBenchmark.cc:215
cpp/core/shuffle/RoundRobinPartitioner.cc:39
cpp/velox/compute/WholeStageResultIterator.cc:255
cpp/core/shuffle/HashPartitioner.cc:55
cpp/velox/tests/VeloxColumnarToRowTest.cc:37
cpp/core/shuffle/FallbackRangePartitioner.cc:44
cpp/velox/benchmarks/ColumnarToRowBenchmark.cc:160
cpp/velox/tests/MemoryManagerTest.cc:343
cpp/core/benchmarks/CompressionBenchmark.cc:306
cpp/core/shuffle/RandomPartitioner.cc:36
cpp/core/utils/qat/QatCodec.cc:152
cpp/velox/shuffle/VeloxShuffleReader.cc:542
cpp/velox/tests/VeloxRowToColumnarTest.cc:36
cpp/velox/tests/MemoryManagerTest.cc:346
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:366
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:416
cpp/velox/benchmarks/ColumnarToRowBenchmark.cc:153
cpp/velox/benchmarks/ParquetWriteBenchmark.cc:162
cpp/velox/benchmarks/ParquetWriteBenchmark.cc:255
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:30
cpp/core/utils/qpl/QplJobPool.cc:70
cpp/velox/memory/VeloxMemoryManager.cc:263
cpp/velox/operators/serializer/VeloxRowToColumnarConverter.cc:107
cpp/velox/memory/VeloxMemoryManager.cc:41
cpp/velox/utils/tests/MemoryPoolUtils.cc:131
cpp/velox/operators/serializer/VeloxRowToColumnarConverter.cc:39
cpp/core/utils/qpl/QplCodec.cc:206
cpp/velox/operators/serializer/VeloxRowToColumnarConverter.cc:183
cpp/velox/memory/VeloxMemoryManager.cc:43
(Fixes: #8520)