[CORE] Use RAS's cost model for legacy transition planner to evaluate cost of transitions#8527
Merged
zhztheplayer merged 7 commits intoapache:mainfrom Jan 15, 2025
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
zhztheplayer
changed the title
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
Member
Author
|
Run Gluten Clickhouse CI on x86 |
JkSelf
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines RAS cost model into transition graph's cost model to unify the cost evaluation code of transitions.
For example, a transition from Arrow Java columnar batch (referred to as Arrow Java batch) to Velox columnar batch (referred to as Velox batch) could be selected from the following candidates:
The transition planner should evaluate the candidates' costs then select a cheaper one (for the case, usually the second one) based on the cost model. After the change, it will reuse RAS's cost model instead of the hard coded transition cost model which will be removed in this PR.
Also, remove the
rough2RAS cost model as unused.