[GLUTEN-8487][VL] adding JDK17 based Centos8 image (#8513)#8539
Merged
zhouyuan merged 3 commits intoapache:mainfrom Jan 15, 2025
Merged
[GLUTEN-8487][VL] adding JDK17 based Centos8 image (#8513)#8539zhouyuan merged 3 commits intoapache:mainfrom
zhouyuan merged 3 commits intoapache:mainfrom
Conversation
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
JkSelf
reviewed
Jan 15, 2025
Contributor
JkSelf
left a comment
JkSelf
left a comment
There was a problem hiding this comment.
LGTM. Just two small comments.
.github/workflows/docker_image.yml
Outdated
| context: . | ||
| file: dev/docker/Dockerfile.centos8-dynamic-build-jdk17 | ||
| push: true | ||
| tags: apache/gluten:centos-8-jdk17 No newline at end of file |
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
wip_docker_jdk17
branch
from
1acf92f to
b66304e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch added JDK17 based Centos 8 image
How was this patch tested?
no tests required