[CORE][VL] Cost model code refactors#8541
Merged
zhztheplayer merged 7 commits intoapache:mainfrom Jan 16, 2025
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
approved these changes
Jan 16, 2025
Member
zhouyuan
left a comment
zhouyuan
left a comment
There was a problem hiding this comment.
a big refactor!
+1 assuming CI green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new independent trait
GlutenCostModelso legacy transition planner's cost model code doesn't have to depend on RAS cost model code.After the change, both legacy transition planner and RAS optimizer will rely on
GlutenCostModelthrough their own API adapters.Also, make costers be registered directly through a individual API of
Component. This will enable the code to create cost model from anywhere without having a Spark session started in advance.