[CORE] Optimize duplicated code for create rel node#8548
[CORE] Optimize duplicated code for create rel node#8548zml1206 merged 2 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
|
|
||
| import scala.collection.JavaConverters._ | ||
|
|
||
| object RelBuilderUtil { |
There was a problem hiding this comment.
Any consideration not adding the APIs to RelBuilder directly?
There was a problem hiding this comment.
RelBuilder is a java class, add it in requires additional type conversion, such as scala Seq.
There was a problem hiding this comment.
There is also Java classes like JList[ExpressionNode] in this file. Can we just put them to RelBuilder? Then make caller call "asJava" when passing the Scala collections which should be trivial. Otherwise developer will have to know 2 different helper classes for similar purposes.
There was a problem hiding this comment.
Mainly it seems inappropriate to call replaceWithExpressionTransformer in RelBuild. Here I extracted part of the logic, stay up replaceWithExpressionTransformer, CI failure unrelated, please take a look again, thank you.
|
Run Gluten Clickhouse CI on x86 |
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)