Skip to content

[MINOR] Fix comment of function VeloxAggregateFunctionsBuilder.create #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zml1206 merged 2 commits into from
Jan 17, 2025
Merged

[MINOR] Fix comment of function VeloxAggregateFunctionsBuilder.create #8549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0f88d
[MINOR] Fix comment of function VeloxAggregateFunctionsBuilder.create
zml1206 Jan 16, 2025
7f2100f
fix
zml1206 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ abstract class HashAggregateExecTransformer(
* @return
* a project rel
*/
def applyExtractStruct(
private def applyExtractStruct(
context: SubstraitContext,
aggRel: RelNode,
operatorId: Long,
Expand Down Expand Up @@ -260,7 +260,7 @@ abstract class HashAggregateExecTransformer(
* Return the output types after partial aggregation through Velox.
* @return
*/
def getPartialAggOutTypes: JList[TypeNode] = {
private def getPartialAggOutTypes: JList[TypeNode] = {
val typeNodeList = new JArrayList[TypeNode]()
groupingExpressions.foreach(
expression => {
Expand Down Expand Up @@ -669,13 +669,13 @@ abstract class HashAggregateExecTransformer(
object VeloxAggregateFunctionsBuilder {

/**
* Create an scalar function for the input aggregate function.
* Create a scalar function for the input aggregate function.
* @param args:
* the function map.
* @param aggregateFunc:
* the input aggregate function.
* @param forMergeCompanion:
* whether this is a special case to solve mixed aggregation phases.
* @param mode:
* the mode of input aggregate function.
* @return
*/
def create(
Expand Down