[GLUTEN-8479][CORE][Part-2] All configurations should be defined through ConfigEntry#8559
Merged
zhztheplayer merged 1 commit intoapache:mainfrom Jan 21, 2025
Merged
Conversation
github-actions
bot
added
CORE
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@jackylee-ch would you please take a look at this PR? |
jackylee-ch
reviewed
Jan 17, 2025
yikf
force-pushed
the
remove-config-val
branch
from
8d77e22 to
273941f
Compare
|
Run Gluten Clickhouse CI on x86 |
yikf
force-pushed
the
remove-config-val
branch
from
273941f to
6bef27b
Compare
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
reviewed
Jan 20, 2025
jackylee-ch
reviewed
Jan 20, 2025
zhztheplayer
changed the title
jackylee-ch
reviewed
Jan 20, 2025
|
|
||
| /** | ||
| * The ReservedKeys retains the configuration constants used internally by Gluten, which are not | ||
| * exposed to users. |
Contributor
There was a problem hiding this comment.
nit: Add a TODO to mv other constant keys to this class.
jackylee-ch
approved these changes
Jan 20, 2025
Contributor
jackylee-ch
left a comment
jackylee-ch
left a comment
There was a problem hiding this comment.
LGTM. cc @baibaichen @philo-he @zhztheplayer
yikf
force-pushed
the
remove-config-val
branch
from
6bef27b to
ef7582b
Compare
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
approved these changes
Jan 21, 2025
Member
zhztheplayer
left a comment
zhztheplayer
left a comment
There was a problem hiding this comment.
This is a solid code cleanup. Thank you very much for the contribution.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, there are three styles for defining Gluten configuration:
This PR aims to uniformly use ConfigEntry to define all configurations. Additionally, for internal-use keys (such as
spark.gluten.ugi.username), use ReservedKeys to definition.How was this patch tested?
GA.