[VL] CMake configuration cleanup to remove variable VELOX_COMPONENTS_PATH#8579
Merged
zhztheplayer merged 1 commit intoapache:mainfrom Jan 21, 2025
Merged
[VL] CMake configuration cleanup to remove variable VELOX_COMPONENTS_PATH#8579zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer merged 1 commit intoapache:mainfrom
Conversation
Yohahaha
approved these changes
Jan 21, 2025
Member
Author
|
Thanks for the review! |
baibaichen
pushed a commit
to baibaichen/gluten
that referenced
this pull request
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VELOX_COMPONENTS_PATHshould be removed and the usages should be replaced by$VELOX_BUILD_PATH/veloxalready. This line (forfacebook::velox::exec_test_lib) was likely missing from a former cleanup. The path does a follow-up on this line.