Skip to content

[GLUTEN-8772][CORE] refactor: Refactoring the usage of SubstraitContext#functionMap#8775

Merged
Yohahaha merged 1 commit intoapache:mainfrom
wypb:refactor_SubstraitContext
Apr 17, 2025
Merged

[GLUTEN-8772][CORE] refactor: Refactoring the usage of SubstraitContext#functionMap#8775
Yohahaha merged 1 commit intoapache:mainfrom
wypb:refactor_SubstraitContext

Conversation

@wypb
Copy link
Copy Markdown
Contributor

@wypb wypb commented Feb 19, 2025 •
edited
Loading

What changes were proposed in this pull request?

  1. Refactor ExpressionTransformer#doTransform(args: java.lang.Object) to ExpressionTransformer#doTransform(context: SubstraitContext)
  2. Remove ExpressionBuilder#newScalarFunction and use SubstraitContext#registerFunction to register functions

(Fixes: #8772)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb changed the title [CORE] Refactoring the use of SubstraitContext#functionMap [GLUTEN-8772][CORE] refactor: Refactoring the use of SubstraitContext#functionMap Feb 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2025

#8772

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from ab1ed1e to d6d83a3 Compare February 19, 2025 08:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from d6d83a3 to 6a060c6 Compare February 19, 2025 08:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2025

Run Gluten Clickhouse CI on x86

@Yohahaha Yohahaha changed the title [GLUTEN-8772][CORE] refactor: Refactoring the use of SubstraitContext#functionMap [GLUTEN-8772][CORE] refactor: Refactoring the usage of SubstraitContext#functionMap Feb 19, 2025
@wypb wypb force-pushed the refactor_SubstraitContext branch from 6a060c6 to 5fc4ee1 Compare February 20, 2025 01:26
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 20, 2025

Run Gluten Clickhouse CI on x86

Yohahaha
Yohahaha approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Yohahaha Yohahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for the work!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 25, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from 3b1abfc to fdf1727 Compare February 25, 2025 09:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 25, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from fdf1727 to 6eb4bbd Compare February 26, 2025 01:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2025

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from 4686438 to 1754a60 Compare February 26, 2025 03:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from 1754a60 to 017db37 Compare February 26, 2025 03:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from 017db37 to 7af61f8 Compare February 27, 2025 08:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 27, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Apr 14, 2025
@zhztheplayer
Copy link
Copy Markdown
Member

zhztheplayer commented Apr 14, 2025

@wypb Would you rebase? Thanks.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from 7060e8a to 2e8b69a Compare April 14, 2025 10:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2025

Run Gluten Clickhouse CI on x86

@wypb
Copy link
Copy Markdown
Contributor Author

wypb commented Apr 14, 2025

@zhztheplayer I have synced the latest code, thank you for your review.

@wypb wypb force-pushed the refactor_SubstraitContext branch from 35b16d2 to 1b91880 Compare April 15, 2025 01:23
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2025

Run Gluten Clickhouse CI on x86

@wypb wypb force-pushed the refactor_SubstraitContext branch from 445ef64 to 606e7e4 Compare April 15, 2025 01:26
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2025

Run Gluten Clickhouse CI on x86

@github-actions github-actions bot removed the stale stale label Apr 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2025

Run Gluten Clickhouse CI on x86

@wypb
Copy link
Copy Markdown
Contributor Author

wypb commented Apr 17, 2025

@zhztheplayer @Yohahaha any comments on this PR? thanks.

@wypb wypb force-pushed the refactor_SubstraitContext branch from 6fcde4b to 307cad7 Compare April 17, 2025 02:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2025

Run Gluten Clickhouse CI on x86

@Yohahaha
Copy link
Copy Markdown
Contributor

Yohahaha commented Apr 17, 2025

please do not rebase when CI is running.

@Yohahaha
Copy link
Copy Markdown
Contributor

Yohahaha commented Apr 17, 2025

GlutenCSVSuite is flaky and not related with current PR, I think we can ignore and merge it. @zhztheplayer any comments?

@Yohahaha
Copy link
Copy Markdown
Contributor

Yohahaha commented Apr 17, 2025

GlutenCSVSuite is flaky and not related with current PR, I think we can ignore and merge it. @zhztheplayer any comments?

cc @philo-he @zhouyuan

@Yohahaha Yohahaha merged commit 55b2e92 into apache:main Apr 17, 2025
47 checks passed
@wypb wypb deleted the refactor_SubstraitContext branch April 17, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yohahaha Yohahaha Yohahaha approved these changes

Assignees

No one assigned

Labels

CLICKHOUSE CORE works for Gluten Core DATA_LAKE VELOX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CORE] Refactoring the use of SubstraitContext#functionMap

3 participants

@wypb @zhztheplayer @Yohahaha