[GLUTEN-8738] Update GlutenSQLQueryTestSuite to match with the original file#8837
Merged
marin-ma merged 3 commits intoapache:mainfrom Mar 2, 2025
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
reviewed
Feb 27, 2025
Member
zhouyuan
left a comment
zhouyuan
left a comment
There was a problem hiding this comment.
Thanks! Indeed we did not verify the unit tests files when upgrading from Spark-34 -> Spark-35
| import org.apache.gluten.utils.{BackendTestSettings, BackendTestUtils} | ||
|
|
||
| import org.apache.spark.{SparkConf, SparkException, SparkThrowable} | ||
| import org.apache.spark.{SparkConf, SparkException, SparkThrowable, TestUtils} |
Member
There was a problem hiding this comment.
Was this copied from Spark-352 code?
it seems we are upgrading to Spark-354, does this mean we should upgrade this file for future updates?
#8597
Contributor
Author
There was a problem hiding this comment.
Just checked the file contents are identical for spark3.5.2 and spark3.5.4.
FelixYBW
approved these changes
Mar 2, 2025
zhouyuan
pushed a commit
to GlutenPerfBot/gluten
that referenced
this pull request
Mar 2, 2025
Contributor
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GlutenSQLQueryTestSuite.scalaoriginates fromorg.apache.spark.sql.SQLQueryTestSuite, but the content of the file is not aligned with spark. It seems like the file was created by simply copying and pasting from the old file from spark33/spark34 shim when supporting new Spark versions in Gluten.Update the content of
GlutenSQLQueryTestSuite.scalaand mark the modifications for Gluten. Developers who will be working on supporting future Spark versions should pay attention to the content changes in the original file in Spark.