Skip to content

[GLUTEN-9008][VL] Support json_object_keys function#9009

Merged
philo-he merged 3 commits intoapache:mainfrom
dcoliversun:jok
Apr 8, 2025
Merged

[GLUTEN-9008][VL] Support json_object_keys function#9009
philo-he merged 3 commits intoapache:mainfrom
dcoliversun:jok

Conversation

@dcoliversun
Copy link
Copy Markdown
Contributor

@dcoliversun dcoliversun commented Mar 15, 2025

What changes were proposed in this pull request?

This PR aims to support json_object_keys function.

(Fixes: #9008)

How was this patch tested?

unit tests

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Mar 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 15, 2025

#9008

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 15, 2025

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 15, 2025

Run Gluten Clickhouse CI on x86

@dcoliversun dcoliversun mentioned this pull request Mar 17, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2025

Run Gluten Clickhouse CI on x86

@dcoliversun
Copy link
Copy Markdown
Contributor Author

dcoliversun commented Mar 31, 2025

@philo-he @jackylee-ch I believe it's ready to review. Relative tests pass but other unrelated tests failed.

@jackylee-ch
Copy link
Copy Markdown
Contributor

jackylee-ch commented Mar 31, 2025 •
edited
Loading

https://github.com/apache/incubator-gluten/pull/9009/checks?check_run_id=39674902439
It seems we still have some related failed tests, could you check it?

@dcoliversun
Copy link
Copy Markdown
Contributor Author

dcoliversun commented Mar 31, 2025 •
edited
Loading

@jackylee-ch I know why. I only check JsonFunctionsValidateSuite.scala added in this PR and ignore JsonFunctionsSuite in spark.

I will fix it. Thanks for your help :)

@github-actions github-actions bot added the BUILD label Mar 31, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2025

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

Run Gluten Clickhouse CI on x86

@dcoliversun dcoliversun mentioned this pull request Apr 1, 2025
Closed
@dcoliversun
Support json_object_keys function
d22427d 
update

remove json_object_keys from ch
@github-actions github-actions bot removed the BUILD label Apr 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2025

Run Gluten Clickhouse CI on x86

@dcoliversun
Copy link
Copy Markdown
Contributor Author

dcoliversun commented Apr 7, 2025

@philo-he @jackylee-ch I believe it's ready to review, thanks.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

Run Gluten Clickhouse CI on x86

@dcoliversun
Copy link
Copy Markdown
Contributor Author

dcoliversun commented Apr 7, 2025

@philo-he @jackylee-ch The comments are addressed. Some tests failed and no one is relative to this PR.

jackylee-ch
jackylee-ch reviewed Apr 7, 2025
View reviewed changes
backends-velox/src/test/scala/org/apache/gluten/execution/JsonFunctionsValidateSuite.scala Outdated
}

runQueryAndCompare(
"SELECT json_object_keys(null) " +
Copy link
Copy Markdown
Contributor

@jackylee-ch jackylee-ch Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need read null from relation, otherwise it won't offload to native side.

Copy link
Copy Markdown
Contributor Author

@dcoliversun dcoliversun Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, I see other test with select spark_function(null) from tbl also. I will submit other PR to fix, this case is ok

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

Run Gluten Clickhouse CI on x86

@dcoliversun dcoliversun mentioned this pull request Apr 7, 2025
Closed
@dcoliversun
Copy link
Copy Markdown
Contributor Author

dcoliversun commented Apr 7, 2025

@philo-he @jackylee-ch It's ready to review, and test fails with oom

@jackylee-ch
Copy link
Copy Markdown
Contributor

jackylee-ch commented Apr 8, 2025

@philo-he Any more questions about this pr?

@philo-he philo-he merged commit aa89601 into apache:main Apr 8, 2025
47 checks passed
@dcoliversun dcoliversun deleted the jok branch April 8, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackylee-ch jackylee-ch jackylee-ch approved these changes

@philo-he philo-he philo-he approved these changes

Assignees

No one assigned

Labels

CLICKHOUSE CORE works for Gluten Core VELOX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[VL] Support json_object_keys function

3 participants

@dcoliversun @jackylee-ch @philo-he