Skip to content

[VL] Optimize memory allocation for VeloxRssShuffleReader #9069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kerwin-zk merged 1 commit into from
Mar 25, 2025
Merged

[VL] Optimize memory allocation for VeloxRssShuffleReader #9069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions cpp/velox/shuffle/VeloxShuffleReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,14 +548,18 @@ VeloxRssSortShuffleReaderDeserializer::VeloxRssSortShuffleReaderDeserializer(
batchSize_(batchSize),
veloxCompressionType_(veloxCompressionType),
serde_(getNamedVectorSerde(facebook::velox::VectorSerde::Kind::kPresto)),
deserializeTime_(deserializeTime) {
constexpr uint64_t kMaxReadBufferSize = (1 << 20) - AlignedBuffer::kPaddedSize;
auto buffer = AlignedBuffer::allocate<char>(kMaxReadBufferSize, veloxPool_.get());
in_ = std::make_unique<VeloxInputStream>(std::move(in), std::move(buffer));
deserializeTime_(deserializeTime),
arrowIn_(in) {
serdeOptions_ = {false, veloxCompressionType_};
}

std::shared_ptr<ColumnarBatch> VeloxRssSortShuffleReaderDeserializer::next() {
if (in_ == nullptr) {
constexpr uint64_t kMaxReadBufferSize = (1 << 20) - AlignedBuffer::kPaddedSize;
auto buffer = AlignedBuffer::allocate<char>(kMaxReadBufferSize, veloxPool_.get());
in_ = std::make_unique<VeloxInputStream>(std::move(arrowIn_), std::move(buffer));
}

if (!in_->hasNext()) {
return nullptr;
}
Expand Down
1 change: 1 addition & 0 deletions cpp/velox/shuffle/VeloxShuffleReader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ class VeloxRssSortShuffleReaderDeserializer : public ColumnarBatchIterator {
facebook::velox::serializer::presto::PrestoVectorSerde::PrestoOptions serdeOptions_;
int64_t& deserializeTime_;
std::shared_ptr<VeloxInputStream> in_;
std::shared_ptr<arrow::io::InputStream> arrowIn_;
};

class VeloxShuffleReaderDeserializerFactory {
Expand Down
Loading