Skip to content

[VL] Enable more ut in VeloxTestSettings #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackylee-ch merged 1 commit into from
Apr 2, 2025
Merged

[VL] Enable more ut in VeloxTestSettings #9080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,6 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenExchangeSuite]
// ColumnarShuffleExchangeExec does not support doExecute() method
.exclude("shuffling UnsafeRows in exchange")
// ColumnarShuffleExchangeExec does not support SORT_BEFORE_REPARTITION
.exclude("SPARK-23207: Make repartition() generate consistent output")
// This test will re-run in GlutenExchangeSuite with shuffle partitions > 1
.exclude("Exchange reuse across the whole plan")
enableSuite[GlutenBroadcastJoinSuite]
Expand All @@ -361,9 +359,6 @@ class VeloxTestSettings extends BackendTestSettings {
// Not useful and time consuming.
.exclude("SPARK-33084: Add jar support Ivy URI in SQL")
.exclude("SPARK-33084: Add jar support Ivy URI in SQL -- jar contains udf class")
// Need to support MAP<NullType, NullType>
.exclude(
Copy link
Copy Markdown
Member

@ArnavBalyan ArnavBalyan Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this generating inconsistent result compared to vanilla Spark. Will such cases not automatically fallback?

Copy link
Copy Markdown
Contributor

@Yohahaha Yohahaha Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you open or paste an issue link?

"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
// https://github.com/apache/incubator-gluten/pull/9145.
.exclude("SPARK-17515: CollectLimit.execute() should perform per-partition limits")
// https://github.com/apache/incubator-gluten/pull/9145.
Expand Down
5 changes: 0 additions & 5 deletions gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,8 +551,6 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenExchangeSuite]
// ColumnarShuffleExchangeExec does not support doExecute() method
.exclude("shuffling UnsafeRows in exchange")
// ColumnarShuffleExchangeExec does not support SORT_BEFORE_REPARTITION
.exclude("SPARK-23207: Make repartition() generate consistent output")
// This test will re-run in GlutenExchangeSuite with shuffle partitions > 1
.exclude("Exchange reuse across the whole plan")
enableSuite[GlutenReplaceHashWithSortAggSuite]
Expand Down Expand Up @@ -832,9 +830,6 @@ class VeloxTestSettings extends BackendTestSettings {
// Not useful and time consuming.
.exclude("SPARK-33084: Add jar support Ivy URI in SQL")
.exclude("SPARK-33084: Add jar support Ivy URI in SQL -- jar contains udf class")
// Need to support MAP<NullType, NullType>
.exclude(
"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
// https://github.com/apache/incubator-gluten/pull/9145.
.exclude("SPARK-17515: CollectLimit.execute() should perform per-partition limits")
// https://github.com/apache/incubator-gluten/pull/9145.
Expand Down
5 changes: 0 additions & 5 deletions gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,6 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenExchangeSuite]
// ColumnarShuffleExchangeExec does not support doExecute() method
.exclude("shuffling UnsafeRows in exchange")
// ColumnarShuffleExchangeExec does not support SORT_BEFORE_REPARTITION
.exclude("SPARK-23207: Make repartition() generate consistent output")
// This test will re-run in GlutenExchangeSuite with shuffle partitions > 1
.exclude("Exchange reuse across the whole plan")
enableSuite[GlutenReplaceHashWithSortAggSuite]
Expand Down Expand Up @@ -868,9 +866,6 @@ class VeloxTestSettings extends BackendTestSettings {
// ORC related
.exclude("SPARK-37965: Spark support read/write orc file with invalid char in field name")
.exclude("SPARK-38173: Quoted column cannot be recognized correctly when quotedRegexColumnNames is true")
// Need to support MAP<NullType, NullType>
.exclude(
"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
enableSuite[GlutenSQLQueryTestSuite]
enableSuite[GlutenStatisticsCollectionSuite]
// The output byte size of Velox is different
Expand Down
5 changes: 0 additions & 5 deletions gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,6 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenExchangeSuite]
// ColumnarShuffleExchangeExec does not support doExecute() method
.exclude("shuffling UnsafeRows in exchange")
// ColumnarShuffleExchangeExec does not support SORT_BEFORE_REPARTITION
.exclude("SPARK-23207: Make repartition() generate consistent output")
// This test will re-run in GlutenExchangeSuite with shuffle partitions > 1
.exclude("Exchange reuse across the whole plan")
enableSuite[GlutenReplaceHashWithSortAggSuite]
Expand Down Expand Up @@ -889,9 +887,6 @@ class VeloxTestSettings extends BackendTestSettings {
// ORC related
.exclude("SPARK-37965: Spark support read/write orc file with invalid char in field name")
.exclude("SPARK-38173: Quoted column cannot be recognized correctly when quotedRegexColumnNames is true")
// Need to support MAP<NullType, NullType>
.exclude(
"SPARK-27619: When spark.sql.legacy.allowHashOnMapType is true, hash can be used on Maptype")
enableSuite[GlutenSQLQueryTestSuite]
enableSuite[GlutenStatisticsCollectionSuite]
// The output byte size of Velox is different
Expand Down
Loading