Skip to content

[VL] Improve native plan validation code#9092

Merged
philo-he merged 6 commits intoapache:mainfrom
philo-he:optimize-validate-func
Mar 26, 2025
Merged

[VL] Improve native plan validation code#9092
philo-he merged 6 commits intoapache:mainfrom
philo-he:optimize-validate-func

Conversation

@philo-he
Copy link
Copy Markdown
Member

@philo-he philo-he commented Mar 21, 2025

What changes were proposed in this pull request?

Make global class reference for NativePlanValidationInfo. It's inefficient to find the class and creat a local reference in each JNI call.
Refactor SubstraitToVeloxPlanValidator.

How was this patch tested?

Existing tests.

@github-actions github-actions bot added the VELOX label Mar 21, 2025
@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@philo-he philo-he marked this pull request as draft March 21, 2025 10:19
@philo-he philo-he marked this pull request as ready for review March 21, 2025 14:15
@philo-he
Copy link
Copy Markdown
Member Author

@zhztheplayer, could you take a look?

Copy link
Copy Markdown
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philo-he philo-he merged commit 1cfee63 into apache:main Mar 26, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants