Skip to content

[CORE][VL] Hide child nodes from implementations of OffloadSingleNode#9220

Merged
zhztheplayer merged 14 commits intoapache:mainfrom
zhztheplayer:wip-hide-single
Apr 7, 2025
Merged

[CORE][VL] Hide child nodes from implementations of OffloadSingleNode#9220
zhztheplayer merged 14 commits intoapache:mainfrom
zhztheplayer:wip-hide-single

Conversation

@zhztheplayer
Copy link
Copy Markdown
Member

@zhztheplayer zhztheplayer commented Apr 3, 2025

Hide child plan nodes from OffloadSingleNode so we can make sure the implementation code is working on a node rather than working on a tree.

So cost-based conditional fallback will be made possible because the rules can be composite arbitrarily in any precedences in rule appliers.

Once an offload rule that needs access to child nodes, user could add a pre-transform or post-transform rule to do that.

@github-actions github-actions bot added CORE works for Gluten Core CLICKHOUSE DATA_LAKE labels Apr 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Run Gluten ClickHouse CI on ARM

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Run Gluten ClickHouse CI on ARM

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Run Gluten ClickHouse CI on ARM

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Run Gluten ClickHouse CI on ARM

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Run Gluten ClickHouse CI on ARM

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2025

Run Gluten ClickHouse CI on ARM

@zhztheplayer zhztheplayer marked this pull request as ready for review April 4, 2025 09:05
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2025

Run Gluten ClickHouse CI on ARM

@zhztheplayer zhztheplayer changed the title [CORE][VL] Hide child nodes from implementations of OffloadSingleNode / RewriteSingleNode [CORE][VL] Hide child nodes from implementations of OffloadSingleNode Apr 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2025

Run Gluten ClickHouse CI on ARM

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2025

Run Gluten ClickHouse CI on ARM

@zhztheplayer zhztheplayer merged commit ee9146d into apache:main Apr 7, 2025
50 checks passed
@GlutenPerfBot
Copy link
Copy Markdown
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_04_07_2025_time.csv log/native_master_04_06_2025_5eecd8d5d0_time.csv difference percentage
q1 11.54 11.05 -0.484 95.80%
q2 10.89 12.05 1.159 110.65%
q3 3.13 3.56 0.430 113.71%
q4 50.69 52.96 2.265 104.47%
q5 9.61 7.17 -2.442 74.59%
q6 4.32 4.55 0.229 105.30%
q7 5.40 4.39 -1.010 81.30%
q8 3.48 4.07 0.591 116.98%
q9 15.61 14.46 -1.154 92.61%
q10 11.52 11.80 0.287 102.49%
q11 28.41 28.59 0.179 100.63%
q12 1.78 2.29 0.515 129.03%
q13 6.94 6.47 -0.473 93.18%
q14a 42.93 45.45 2.519 105.87%
q14b 39.73 40.88 1.146 102.88%
q15 2.57 2.14 -0.424 83.47%
q16 4.54 6.51 1.967 143.30%
q17 5.65 6.64 0.985 117.43%
q18 8.44 8.31 -0.139 98.36%
q19 4.15 3.79 -0.351 91.53%
q20 1.97 2.03 0.059 103.02%
q21 1.26 0.87 -0.387 69.30%
q22 2.61 3.94 1.324 150.63%
q23a 62.57 61.46 -1.110 98.23%
q23b 73.69 72.98 -0.713 99.03%
q24a 71.95 74.97 3.014 104.19%
q24b 70.27 67.79 -2.477 96.48%
q25 6.27 5.50 -0.771 87.72%
q26 2.42 2.39 -0.031 98.74%
q27 3.46 2.78 -0.679 80.38%
q28 17.21 17.31 0.101 100.59%
q29 7.48 7.67 0.192 102.56%
q30 5.17 5.80 0.633 112.25%
q31 7.75 7.89 0.136 101.75%
q32 1.83 1.59 -0.237 87.04%
q33 3.43 3.81 0.381 111.10%
q34 3.31 3.75 0.441 113.30%
q35 6.70 7.27 0.563 108.40%
q36 2.59 2.54 -0.051 98.02%
q37 3.35 3.00 -0.346 89.66%
q38 11.29 11.73 0.449 103.98%
q39a 4.37 4.08 -0.295 93.25%
q39b 4.25 4.14 -0.110 97.41%
q40 3.37 3.56 0.192 105.70%
q41 0.64 0.66 0.018 102.78%
q42 0.79 0.55 -0.242 69.42%
q43 2.09 1.95 -0.138 93.37%
q44 6.53 5.97 -0.558 91.45%
q45 3.27 3.51 0.236 107.23%
q46 3.73 3.35 -0.381 89.79%
q47 10.15 9.67 -0.477 95.30%
q48 3.50 3.06 -0.442 87.38%
q49 6.81 5.53 -1.279 81.23%
q50 16.73 17.45 0.722 104.32%
q51 7.49 7.81 0.323 104.32%
q52 0.87 0.77 -0.097 88.83%
q53 1.62 1.74 0.126 107.79%
q54 5.72 5.52 -0.194 96.61%
q55 0.63 0.79 0.157 125.00%
q56 4.62 4.26 -0.361 92.19%
q57 6.35 6.28 -0.072 98.86%
q58 3.60 3.56 -0.030 99.16%
q59 3.94 3.87 -0.078 98.03%
q60 5.37 4.95 -0.421 92.15%
q61 4.29 4.75 0.461 110.74%
q62 2.82 2.89 0.066 102.33%
q63 1.58 1.34 -0.235 85.11%
q64 34.94 35.92 0.981 102.81%
q65 11.14 10.93 -0.213 98.08%
q66 3.56 2.94 -0.621 82.57%
q67 57.82 57.84 0.025 100.04%
q68 3.51 3.15 -0.357 89.83%
q69 5.30 5.27 -0.030 99.43%
q70 5.75 6.02 0.274 104.76%
q71 4.42 5.04 0.624 114.12%
q72 20.27 20.35 0.081 100.40%
q73 2.89 3.16 0.273 109.47%
q74 17.67 16.87 -0.800 95.47%
q75 22.69 22.77 0.075 100.33%
q76 6.78 7.24 0.462 106.82%
q77 2.33 2.48 0.146 106.26%
q78 32.83 34.31 1.480 104.51%
q79 3.83 3.89 0.061 101.60%
q80 9.78 10.92 1.144 111.69%
q81 6.37 6.90 0.529 108.31%
q82 5.32 5.71 0.388 107.29%
q83 2.06 1.54 -0.525 74.54%
q84 2.90 2.44 -0.461 84.13%
q85 6.52 6.64 0.119 101.82%
q86 2.15 1.96 -0.185 91.37%
q87 11.67 11.64 -0.029 99.76%
q88 15.43 15.32 -0.114 99.26%
q89 2.74 2.20 -0.543 80.20%
q90 1.94 2.34 0.398 120.49%
q91 3.95 3.71 -0.240 93.92%
q92 1.50 1.68 0.174 111.58%
q93 23.34 23.73 0.392 101.68%
q94 8.28 8.38 0.099 101.19%
q9 54.89 56.04 1.150 102.09%
q5 1.99 2.29 0.300 115.05%
q96 10.70 10.13 -0.564 94.73%
q97 2.36 2.57 0.210 108.93%
q98 5.34 5.37 0.031 100.57%
q99 0.36 0.56 0.203 156.40%
total 1168.34 1176.45 8.110 100.69%

@GlutenPerfBot
Copy link
Copy Markdown
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_04_07_2025_time.csv log/native_master_04_06_2025_5eecd8d5d0_time.csv difference percentage
q1 24.61 25.48 0.868 103.52%
q2 26.21 24.58 -1.632 93.77%
q3 33.16 32.52 -0.645 98.06%
q4 27.80 28.27 0.475 101.71%
q5 60.52 60.58 0.059 100.10%
q6 6.99 8.73 1.734 124.80%
q7 39.83 40.83 0.999 102.51%
q8 60.05 63.42 3.367 105.61%
q9 96.53 90.92 -5.615 94.18%
q10 43.11 41.66 -1.452 96.63%
q11 17.13 16.10 -1.035 93.96%
q12 17.53 17.21 -0.329 98.12%
q13 23.98 25.17 1.197 104.99%
q14 12.53 12.56 0.033 100.27%
q15 26.95 25.49 -1.459 94.59%
q16 12.51 13.28 0.772 106.17%
q17 74.49 73.61 -0.882 98.82%
q18 112.50 116.21 3.703 103.29%
q19 17.49 23.18 5.693 132.55%
q20 25.48 24.17 -1.303 94.88%
q21 171.82 174.01 2.187 101.27%
q22 10.19 11.33 1.136 111.15%
total 941.44 949.31 7.869 100.84%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants