Skip to content

[VL] Celeborn shuffle reader OOM with many empty input stream#9221

Merged
marin-ma merged 1 commit intoapache:mainfrom
marin-ma:rss-reader-oom
Apr 4, 2025
Merged

[VL] Celeborn shuffle reader OOM with many empty input stream#9221
marin-ma merged 1 commit intoapache:mainfrom
marin-ma:rss-reader-oom

Conversation

@marin-ma
Copy link
Copy Markdown
Contributor

@marin-ma marin-ma commented Apr 3, 2025

Below code piece will create a buffered input stream on native side. The buffer is released on close() called when EOS is reached in readValue(). For empty input stream, the readValue function is never called, and the buffered memory can only be released at task end.

      ShuffleReaderJniWrapper
        .create(runtime)
        .readStream(shuffleReaderHandle, byteIn))

@github-actions github-actions bot added the VELOX label Apr 3, 2025
@marin-ma marin-ma marked this pull request as draft April 3, 2025 16:39
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@marin-ma marin-ma merged commit 27150c8 into apache:main Apr 4, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants