Skip to content

[GLUTEN-9240][VL] Write NULL value into relation in gluten unit tests#9241

Merged
jackylee-ch merged 3 commits intoapache:mainfrom
dcoliversun:gluten-9240
Apr 8, 2025
Merged

[GLUTEN-9240][VL] Write NULL value into relation in gluten unit tests#9241
jackylee-ch merged 3 commits intoapache:mainfrom
dcoliversun:gluten-9240

Conversation

@dcoliversun
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR aims to write NULL value into relation in gluten unit tests, otherwise it won't offload to native side.

(Fixes: #9240)

How was this patch tested?

Pass original unit tests.

@github-actions github-actions bot added the VELOX label Apr 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

#9240

@dcoliversun
Copy link
Copy Markdown
Contributor Author

cc @jackylee-ch

@@ -54,9 +54,21 @@ class JsonFunctionsValidateSuite extends FunctionsValidateSuite {
runQueryAndCompare(
s"select l_orderkey, json_array_length('[1,2,3,4]') " +
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case should also read from relation, could you rewrite it as well?
BTW, ther are same problems with get_json_object.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I check other tests also.

@dcoliversun
Copy link
Copy Markdown
Contributor Author

@jackylee-ch gentle ping 😄 it's ready to merge

@jackylee-ch jackylee-ch merged commit d5472d1 into apache:main Apr 8, 2025
45 checks passed
@dcoliversun dcoliversun deleted the gluten-9240 branch April 8, 2025 12:41
@GlutenPerfBot
Copy link
Copy Markdown
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_04_08_2025_time.csv log/native_master_04_07_2025_ee9146df22_time.csv difference percentage
q1 11.19 11.54 0.343 103.07%
q2 11.46 10.89 -0.571 95.02%
q3 2.91 3.13 0.228 107.83%
q4 51.84 50.69 -1.150 97.78%
q5 9.00 9.61 0.611 106.79%
q6 4.92 4.32 -0.601 87.80%
q7 5.06 5.40 0.336 106.63%
q8 4.09 3.48 -0.614 85.01%
q9 13.62 15.61 1.991 114.62%
q10 13.59 11.52 -2.074 84.74%
q11 28.32 28.41 0.094 100.33%
q12 2.83 1.78 -1.052 62.78%
q13 6.95 6.94 -0.010 99.85%
q14a 43.86 42.93 -0.933 97.87%
q14b 39.04 39.73 0.698 101.79%
q15 3.22 2.57 -0.648 79.85%
q16 4.59 4.54 -0.045 99.01%
q17 6.65 5.65 -0.998 84.99%
q18 7.36 8.44 1.089 114.80%
q19 3.15 4.15 0.999 131.75%
q20 3.23 1.97 -1.257 61.01%
q21 1.70 1.26 -0.439 74.19%
q22 3.54 2.61 -0.921 73.94%
q23a 60.90 62.57 1.668 102.74%
q23b 71.70 73.69 1.989 102.77%
q24a 69.46 71.95 2.491 103.59%
q24b 69.43 70.27 0.844 101.22%
q25 5.22 6.27 1.055 120.22%
q26 2.36 2.42 0.062 102.65%
q27 2.47 3.46 0.991 140.13%
q28 17.70 17.21 -0.490 97.23%
q29 7.63 7.48 -0.150 98.03%
q30 5.01 5.17 0.157 103.13%
q31 8.97 7.75 -1.223 86.37%
q32 1.78 1.83 0.050 102.78%
q33 4.44 3.43 -1.012 77.20%
q34 3.71 3.31 -0.400 89.24%
q35 6.52 6.70 0.187 102.87%
q36 2.52 2.59 0.070 102.77%
q37 2.96 3.35 0.393 113.29%
q38 12.55 11.29 -1.263 89.94%
q39a 3.74 4.37 0.628 116.79%
q39b 3.96 4.25 0.294 107.44%
q40 4.00 3.37 -0.629 84.27%
q41 1.38 0.64 -0.733 46.81%
q42 0.83 0.79 -0.037 95.58%
q43 1.97 2.09 0.114 105.78%
q44 6.57 6.53 -0.040 99.39%
q45 3.20 3.27 0.069 102.17%
q46 4.01 3.73 -0.278 93.08%
q47 9.43 10.15 0.711 107.54%
q48 3.47 3.50 0.034 100.99%
q49 5.57 6.81 1.239 122.23%
q50 16.76 16.73 -0.030 99.82%
q51 7.13 7.49 0.357 105.01%
q52 1.03 0.87 -0.165 83.97%
q53 1.52 1.62 0.091 105.99%
q54 6.01 5.72 -0.293 95.13%
q55 1.13 0.63 -0.501 55.71%
q56 3.78 4.62 0.839 122.18%
q57 6.56 6.35 -0.204 96.89%
q58 2.57 3.60 1.027 139.98%
q59 4.54 3.94 -0.600 86.81%
q60 4.68 5.37 0.684 114.62%
q61 4.61 4.29 -0.323 93.00%
q62 2.77 2.82 0.052 101.88%
q63 1.37 1.58 0.210 115.38%
q64 35.21 34.94 -0.276 99.22%
q65 11.74 11.14 -0.605 94.85%
q66 2.72 3.56 0.843 131.00%
q67 58.02 57.82 -0.203 99.65%
q68 2.99 3.51 0.521 117.45%
q69 4.99 5.30 0.312 106.25%
q70 5.90 5.75 -0.158 97.33%
q71 4.52 4.42 -0.104 97.69%
q72 21.64 20.27 -1.377 93.64%
q73 2.94 2.89 -0.050 98.29%
q74 17.34 17.67 0.337 101.94%
q75 22.62 22.69 0.077 100.34%
q76 6.84 6.78 -0.063 99.08%
q77 2.71 2.33 -0.380 85.96%
q78 33.61 32.83 -0.777 97.69%
q79 3.51 3.83 0.313 108.91%
q80 10.70 9.78 -0.920 91.40%
q81 6.53 6.37 -0.163 97.51%
q82 5.55 5.32 -0.232 95.82%
q83 1.44 2.06 0.618 142.75%
q84 2.74 2.90 0.168 106.15%
q85 6.26 6.52 0.257 104.11%
q86 2.89 2.15 -0.741 74.35%
q87 11.79 11.67 -0.123 98.96%
q88 15.49 15.43 -0.057 99.63%
q89 2.28 2.74 0.459 120.09%
q90 2.40 1.94 -0.458 80.91%
q91 3.74 3.95 0.216 105.79%
q92 1.89 1.50 -0.390 79.37%
q93 22.73 23.34 0.601 102.65%
q94 9.07 8.28 -0.786 91.33%
q9 54.85 54.89 0.042 100.08%
q5 1.89 1.99 0.096 105.08%
q96 10.56 10.70 0.140 101.33%
q97 2.72 2.36 -0.366 86.56%
q98 5.45 5.34 -0.108 98.01%
q99 0.65 0.36 -0.291 55.33%
total 1168.95 1168.34 -0.614 99.95%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write NULL value into relation in gluten unit test

3 participants