[GLUTEN-9240][VL] Write NULL value into relation in gluten unit tests#9241
Merged
jackylee-ch merged 3 commits intoapache:mainfrom Apr 8, 2025
Merged
[GLUTEN-9240][VL] Write NULL value into relation in gluten unit tests#9241jackylee-ch merged 3 commits intoapache:mainfrom
jackylee-ch merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
cc @jackylee-ch |
jackylee-ch
reviewed
Apr 7, 2025
| @@ -54,9 +54,21 @@ class JsonFunctionsValidateSuite extends FunctionsValidateSuite { | |||
| runQueryAndCompare( | |||
| s"select l_orderkey, json_array_length('[1,2,3,4]') " + | |||
Contributor
There was a problem hiding this comment.
This case should also read from relation, could you rewrite it as well?
BTW, ther are same problems with get_json_object.
Contributor
Author
There was a problem hiding this comment.
ok, I check other tests also.
jackylee-ch
approved these changes
Apr 8, 2025
jackylee-ch
approved these changes
Apr 8, 2025
Contributor
Author
|
@jackylee-ch gentle ping 😄 it's ready to merge |
zhouyuan
pushed a commit
to zhouyuan/gluten
that referenced
this pull request
Apr 8, 2025
Contributor
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to write NULL value into relation in gluten unit tests, otherwise it won't offload to native side.
(Fixes: #9240)
How was this patch tested?
Pass original unit tests.