[GLUTEN-9244][CORE] Change the way of passing default timezone to native config#9249
Merged
philo-he merged 4 commits intoapache:mainfrom Apr 10, 2025
Merged
[GLUTEN-9244][CORE] Change the way of passing default timezone to native config#9249philo-he merged 4 commits intoapache:mainfrom
philo-he merged 4 commits intoapache:mainfrom
Conversation
…AL_TIMEZONE is not set
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Member
philo-he
reviewed
Apr 9, 2025
Member
There was a problem hiding this comment.
Maybe, with this fix, we can remove GLUTEN_DEFAULT_SESSION_TIMEZONE, kDefaultSessionTimezone and the relevant code.
I suggest to change the below code to throw exception if valueExists returns false or veloxCfg_->get<std::string>(kSessionTimezone, "") returns empty string, since we always expect the session timezone is set by user or set with the default value.
|
Run Gluten Clickhouse CI on x86 |
philo-he
changed the title
philo-he
approved these changes
Apr 10, 2025
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Looks good! The construction of QueryConfig will check the validity of configured timezone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #9244)
How was this patch tested?