[CORE] Refine the test with specified spark version#9274
Merged
zhztheplayer merged 1 commit intoapache:mainfrom Apr 10, 2025
Merged
[CORE] Refine the test with specified spark version#9274zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer merged 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
Yohahaha
approved these changes
Apr 9, 2025
Contributor
Yohahaha
left a comment
Yohahaha
left a comment
There was a problem hiding this comment.
nice refactoring, thank you!
Contributor
|
may need to verify the total count of passed UT does not decreased. |
Contributor
Author
|
@Yohahaha Thanks for your review. I checked the,
It works fine as expected. |
zhztheplayer
reviewed
Apr 9, 2025
yikf
force-pushed
the
simple-testWithSpecifiedSparkVersion
branch
from
acdfab1 to
f14772d
Compare
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
reviewed
Apr 10, 2025
yikf
force-pushed
the
simple-testWithSpecifiedSparkVersion
branch
from
f14772d to
ceb368a
Compare
|
Run Gluten Clickhouse CI on x86 |
yikf
force-pushed
the
simple-testWithSpecifiedSparkVersion
branch
from
ceb368a to
00a9939
Compare
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
reviewed
Apr 10, 2025
|
|
||
| testWithSpecifiedSparkVersion( | ||
| "iceberg bucketed join partition value not exists partial cluster", Array("3.4", "3.5")) { | ||
| "iceberg bucketed join partition value not exists partial cluster", "3.4", "3.5") { |
Contributor
There was a problem hiding this comment.
nit: this can also be changed to testWithMinSparkVersion
Contributor
Author
There was a problem hiding this comment.
thanks, is should be all.
|
|
||
| testWithSpecifiedSparkVersion("iceberg bucketed join partition value not exists", | ||
| Array("3.4", "3.5")) { | ||
| "3.4", "3.5") { |
Contributor
There was a problem hiding this comment.
nit: this can also be changed to testWithMinSparkVersion
yikf
force-pushed
the
simple-testWithSpecifiedSparkVersion
branch
from
00a9939 to
f567653
Compare
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
approved these changes
Apr 10, 2025
yikf
force-pushed
the
simple-testWithSpecifiedSparkVersion
branch
from
f567653 to
4ebf0c4
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to refine the test with specified spark version.
for example, before, testWithSpecifiedSparkVersion(" XXX ", Some (" 3.3 ")) can let dev think only in 3.3 test, but the reality is above 3.3 is tested.
How was this patch tested?
GA