[GLUTEN-9279] Not pulling out expression from PartialMerge aggregate function to avoid invalid reference binding in ProjectExecTransformer#9280
Merged
liujiayi771 merged 7 commits intoapache:mainfrom Apr 21, 2025
Conversation
…lid reference binding in ProjectExec
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
zml1206
approved these changes
Apr 11, 2025
Contributor
zml1206
left a comment
zml1206
left a comment
There was a problem hiding this comment.
One nit, thank you, cc @liujiayi771
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
liujiayi771
reviewed
Apr 11, 2025
liujiayi771
reviewed
Apr 11, 2025
|
Run Gluten ClickHouse CI on ARM |
Contributor
|
@Z1Wu CH UT |
Contributor
Author
|
Unable to see the details of failed UT. Where could I get the username and password of jenkins. |
|
Run Gluten ClickHouse CI on ARM |
Contributor
|
cc @baibaichen. |
liujiayi771
approved these changes
Apr 18, 2025
zml1206
pushed a commit
to zml1206/gluten
that referenced
this pull request
Apr 22, 2025
…function to avoid invalid reference binding in ProjectExecTransformer (apache#9280)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pulling out expression from
PartialMergeaggregate function results in invalid reference binding inProjectExecTransformerwhen there aremerge_sumandpartial_countaggreagate function with non-attribute expression in sameHashAggregate.Fixes issue: #9279
How was this patch tested?
UnitTest