[VL] Remove param original of ColumnarPartialProjectExec#9290
Merged
zml1206 merged 1 commit intoapache:mainfrom Apr 11, 2025
Merged
[VL] Remove param original of ColumnarPartialProjectExec#9290zml1206 merged 1 commit intoapache:mainfrom
zml1206 merged 1 commit intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten ClickHouse CI on ARM |
zml1206
commented
Apr 10, 2025
| } | ||
| if (original.output.isEmpty) { | ||
| return ValidationResult.failed("Project fallback because output is empty") | ||
| } |
Contributor
Author
There was a problem hiding this comment.
If original.output is empty, then replacedAliasUdf must be also empty, repeat the following judgment.
| original = canonicalized, | ||
| child = child.canonicalized | ||
| )(replacedAliasUdf.map(QueryPlan.normalizeExpressions(_, child.output))) | ||
| super |
jinchengchenghh
approved these changes
Apr 10, 2025
zml1206
added a commit
to zml1206/gluten
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify plan.
How was this patch tested?
Existing ut.