Skip to content

[VL] Fix weekly build job on Centos 7#9294

Merged
zhouyuan merged 4 commits intoapache:mainfrom
philo-he:fix-weekly
Apr 12, 2025
Merged

[VL] Fix weekly build job on Centos 7#9294
zhouyuan merged 4 commits intoapache:mainfrom
philo-he:fix-weekly

Conversation

@philo-he
Copy link
Copy Markdown
Member

@philo-he philo-he commented Apr 10, 2025

What changes were proposed in this pull request?

This issue was related to the recent pr #9207 which changes the script to use upstream Velox wget_and_untar function.

@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

cd "${DEPENDENCY_DIR}"
wget_and_untar https://github.com/davea42/libdwarf-code/archive/refs/tags/20210528.tar.gz dwarf
cd dwarf
pushd dwarf
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the dwarf is introduced by other dependency, not the one here

Copy link
Copy Markdown
Member Author

@philo-he philo-he Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouyuan, thanks for your comment!
The installation for dwarf succeeds as you noted. But it doesn't go back to the original directory. Then, dwarf directory will be wrongly used when executing the build commands for other dependency. This issue was related to the recent pr #9207 which changes the script to use upstream Velox wget_and_untar function.

This pr has fixed the failure. See
https://github.com/apache/incubator-gluten/actions/runs/14413849930/job/40427128080?pr=9294. We can merge this pr now if no more comment (please ignore the latest CI failure since we need some code changes in yml file simply for pr validation and I have reverted those changes).

@github-actions github-actions bot removed the INFRA label Apr 12, 2025
@philo-he philo-he marked this pull request as ready for review April 12, 2025 14:39
Copy link
Copy Markdown
Member

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks!

@zhouyuan zhouyuan merged commit 9687247 into apache:main Apr 12, 2025
44 of 46 checks passed
@philo-he philo-he deleted the fix-weekly branch April 28, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants