[GLUTEN-9313][VL] ColumnarPartialProject supports built-in but blacklisted function#9315
Merged
jinchengchenghh merged 1 commit intoapache:mainfrom Apr 17, 2025
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
Contributor
|
Why it happens, do we need to optimize re2?
|
jinchengchenghh
approved these changes
Apr 14, 2025
Contributor
|
We may extend to all native backend not supported expressions, blacklist expression is one of it. |
jackylee-ch
approved these changes
Apr 14, 2025
Contributor
jackylee-ch
left a comment
There was a problem hiding this comment.
+1. We need a better way to find all the unsupported/blacklisted functions.
Contributor
|
Can you rebase? Thanks! |
b5fd879 to
467c121
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
@jinchengchenghh I think so. We also tried another native regexp lib named |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
ColumnaPartialProjectcan also supports build-in functions, especially the blacklist expressions.One typical scenario is regexp. The native regexp lib
re2is much slower than Java regexp lib, and also has some semantic difference with Java lib.Take a simple sql in our production as an example
In this PR, try to use
ColumnarPartialProjectto handle the blacklist expressions.(Fixes: #9313)
How was this patch tested?
more UT