[VL] Count total JVM memory as the on-heap portion for the off-heap sizing feature#9321
Merged
zhztheplayer merged 5 commits intoapache:mainfrom Apr 15, 2025
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
approved these changes
Apr 15, 2025
| if (size + usedOffHeapBytesNow + usedOnHeapBytes > MAX_MEMORY_IN_BYTES) { | ||
| // Adds the total JVM memory which is the actual memory the JVM occupied from the operating | ||
| // system into the counter. | ||
| if (size + usedOffHeapBytesNow + totalHeapMemory > MAX_MEMORY_IN_BYTES) { |
Member
There was a problem hiding this comment.
I got the idea and this fix looks correct to me
Cc: @zhli1142015
warrenzhu25
pushed a commit
to warrenzhu25/gluten
that referenced
this pull request
Jan 10, 2026
…izing feature (apache#9321) (cherry picked from commit c2c8271) Change-Id: I0c9affbdc6db4d2c48118ffd8fd0f20fde576692 Reviewed-on: https://bigdataoss-internal-review.googlesource.com/c/third_party/apache/incubator-gluten/+/115776 Reviewed-by: Preetesh Verma <preeteshverma@google.com> Tested-by: Srinivas S T <srst@google.com> Reviewed-by: Revanth Venkat Mikkilineni <revanthvenkat@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the feature uses
total memory - free memoryas the on-heap occupied size, which was wrong. The free memory is unused by JVM but not yet returned to the OS. The heap occupation from operating system is always the total JVM memory.The patch corrects the calculation by using the total JVM memory instead.
Related:
#5439
#9276
#8600
With some minor code cleanups in passing.