[GLUTEN-9243][VL] Fix cuda docker image#9333
Conversation
The image `ghcr.io/facebookincubator/velox-dev:adapters` is not avaiable on ARM Signed-off-by: Yuan Zhou <yuan.zhou@ibm.com>
Signed-off-by: Yuan Zhou <yuan.zhou@ibm.com>
Signed-off-by: Yuan Zhou <yuan.zhou@ibm.com>
This reverts commit 3966966.
Signed-off-by: Yuan Zhou <yuan.zhou@ibm.com>
philo-he
changed the title
Signed-off-by: Yuan Zhou <yuan.zhou@ibm.com>
| if [ $ENABLE_GPU == "ON" ]; then | ||
| COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GPU=ON -DVELOX_ENABLE_CUDF=ON" | ||
| # the cuda default options are for Centos9 image from Meta | ||
| COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GPU=ON -DVELOX_ENABLE_CUDF=ON -DCMAKE_CUDA_ARCHITECTURES=70 -DCMAKE_CUDA_COMPILER=/usr/local/cuda-12.8/bin/nvcc" |
There was a problem hiding this comment.
I use the ENV here but without CUDA_COMPILER https://github.com/apache/incubator-gluten/pull/9333/files#diff-395a263b6f69bd7ef4991face3666e100acdd60e47f4b28e0737adbbf5fb945aR12,is all the environment CUDA COMPILER this path? Do we need to make it an environment variable in docker image?
There was a problem hiding this comment.
In my tests it will report cuda identifier is undefined in device code if not setting these two variables. Note the GHA runner does not have NV GPU installed.
CUDA_ARCHITECTURESis able to read from CMAKE_CUDA_ARCHITECTURES
https://cmake.org/cmake/help/v3.28/prop_tgt/CUDA_ARCHITECTURES.html
however it seems there's no similar variable like CUDA_COMPILERS
| with: | ||
| images: ${{ env.DOCKERHUB_REPO }} | ||
| tags: centos-8-jdk8 | ||
| tags: vcpkg-centos-8 |
There was a problem hiding this comment.
Looks like the tag is changed, some docker images in docker hub maybe duplicated. I don't suggest to change the tag, the user may face compatible issue.
There was a problem hiding this comment.
it's not changed actually - it's diff issue from github. here's the full file:
https://github.com/apache/incubator-gluten/blob/245ea1e22cf81e158fa101aa6b6d970ac17381f9/.github/workflows/docker_image.yml#L63
|
Thanks for your fix. |
|
The fix does not work on GHA due to:
|
3 participants
What changes were proposed in this pull request?
The image
ghcr.io/facebookincubator/velox-dev:adaptersis not avaiable on ARMfollowup on #9229
Signed-off-by: Yuan Zhou yuan.zhou@ibm.com
How was this patch tested?
pass GHA