Skip to content

[Gluten-8792][CH] Support delta project incrementMetric expr#9353

Merged
loneylee merged 6 commits intoapache:mainfrom
loneylee:8792
Apr 22, 2025
Merged

[Gluten-8792][CH] Support delta project incrementMetric expr#9353
loneylee merged 6 commits intoapache:mainfrom
loneylee:8792

Conversation

@loneylee
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #8792)

How was this patch tested?

test by ut

@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@loneylee loneylee requested a review from Copilot April 17, 2025 11:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • backends-clickhouse/src-delta-32/test/scala/org/apache/spark/sql/execution/GlutenDeltaExpressionSuite.scala: Language not supported
  • backends-clickhouse/src-delta/main/scala/org/apache/gluten/component/CHDeltaComponent.scala: Language not supported
  • backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHMetricsApi.scala: Language not supported
  • backends-clickhouse/src/main/scala/org/apache/gluten/metrics/FilterMetricsUpdater.scala: Language not supported
  • backends-clickhouse/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala: Language not supported
  • backends-clickhouse/src/main/scala/org/apache/gluten/metrics/ProjectMetricsUpdater.scala: Language not supported
  • gluten-delta/src-delta-32/main/scala/org/apache/gluten/execution/DeltaProjectExecTransformer.scala: Language not supported
Comments suppressed due to low confidence (1)

cpp-ch/local-engine/Parser/RelParsers/FilterRelParser.cpp:42

  • Please add unit tests to verify that literal conditions are handled as expected and do not introduce unwanted side effects.
if (filter_rel.condition().has_scalar_function() || filter_rel.condition().has_literal())

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loneylee loneylee merged commit ef5e8af into apache:main Apr 22, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CH] Support delta project expr of IncrementMetric

3 participants