Skip to content

[GLUTEN][VL] Minor refactor config use in ColumnarCachedBatchSerialize#9408

Merged
zhztheplayer merged 1 commit intoapache:mainfrom
zjuwangg:m_minorRefactor
Apr 24, 2025
Merged

[GLUTEN][VL] Minor refactor config use in ColumnarCachedBatchSerialize#9408
zhztheplayer merged 1 commit intoapache:mainfrom
zjuwangg:m_minorRefactor

Conversation

@zjuwangg
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Minor refactor config use in ColumnarCachedBatchSerialize

How was this patch tested?

Existed test.

@github-actions github-actions bot added the VELOX label Apr 24, 2025
@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@wForget wForget changed the title [GLUTEN][INFRA]Minor refactor config use in ColumnarCachedBatchSerialize [GLUTEN][VL]Minor refactor config use in ColumnarCachedBatchSerialize Apr 24, 2025
@wForget wForget changed the title [GLUTEN][VL]Minor refactor config use in ColumnarCachedBatchSerialize [GLUTEN][VL] Minor refactor config use in ColumnarCachedBatchSerialize Apr 24, 2025
Copy link
Copy Markdown
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@zhztheplayer zhztheplayer merged commit 050fb69 into apache:main Apr 24, 2025
47 checks passed
@zhztheplayer
Copy link
Copy Markdown
Member

zhztheplayer commented Apr 24, 2025

I feel we don't need the logic anymore. Will confirm and raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants