Skip to content

[VL] Remove unused logic in ColumnarCachedBatchSerializer#supportsColumnarInput #9413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Apr 24, 2025
Merged

[VL] Remove unused logic in ColumnarCachedBatchSerializer#supportsColumnarInput #9413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions ...s-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarCachedBatchSerializer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,18 +101,7 @@ class ColumnarCachedBatchSerializer extends CachedBatchSerializer with Logging {
}

override def supportsColumnarInput(schema: Seq[Attribute]): Boolean = {
// Note, there is a issue that, if gluten columnar scan is disabled and vanilla Spark
// columnar is enabled, then the following plan would fail.
// InMemoryTableScan
// InMemoryRelation
// (vanilla Spark columnar Scan) Parquet
// The reason is that, Spark will remove the top level `ColumnarToRow` and call
// `convertColumnarBatchToCachedBatch`, but the inside ColumnarBatch is not arrow-based.
// See: `InMemoryRelation.apply()`.
// So we should disallow columnar input if using vanilla Spark columnar scan.
val noVanillaSparkColumnarScan = glutenConf.enableColumnarFileScan ||
!glutenConf.getConf(GlutenConfig.VANILLA_VECTORIZED_READERS_ENABLED)
glutenConf.enableGluten && validateSchema(schema) && noVanillaSparkColumnarScan
glutenConf.enableGluten && validateSchema(schema)
}

override def supportsColumnarOutput(schema: StructType): Boolean = {
Expand Down