Skip to content

[VL] Remove CollectLimit dependency from Offload Rules #9451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Apr 28, 2025
Merged

[VL] Remove CollectLimit dependency from Offload Rules #9451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .../src/main/scala/org/apache/gluten/extension/columnar/offload/OffloadSingleNodeRules.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import org.apache.spark.internal.Logging
import org.apache.spark.sql.catalyst.optimizer.{BuildLeft, BuildRight, BuildSide}
import org.apache.spark.sql.catalyst.plans.logical.Join
import org.apache.spark.sql.execution._
import org.apache.spark.sql.execution.CollectLimitExec
import org.apache.spark.sql.execution.RDDScanTransformer
import org.apache.spark.sql.execution.aggregate.{HashAggregateExec, ObjectHashAggregateExec, SortAggregateExec}
import org.apache.spark.sql.execution.datasources.WriteFilesExec
Expand Down Expand Up @@ -343,14 +342,6 @@ object OffloadOthers {
plan.withReplacement,
plan.seed,
child)
case plan: CollectLimitExec =>
logDebug(s"Columnar Processing for ${plan.getClass} is currently supported.")
val offset = SparkShimLoader.getSparkShims.getCollectLimitOffset(plan)
BackendsApiManager.getSparkPlanExecApiInstance.genColumnarCollectLimitExec(
plan.limit,
plan.child,
offset
)
case plan: RDDScanExec if RDDScanTransformer.isSupportRDDScanExec(plan) =>
logDebug(s"Columnar Processing for ${plan.getClass} is currently supported.")
RDDScanTransformer.getRDDScanTransform(plan)
Expand Down