[GLUTEN-9163][VL][FOLLOWUP] Fix segfault triggered by fixed-width inputs#9766
Merged
marin-ma merged 1 commit intoapache:mainfrom May 29, 2025
Merged
Conversation
Contributor
Author
|
@wangyum Could you try this patch? Thanks! |
Member
|
Thank you @marin-ma. will try it later. |
wangyum
approved these changes
May 29, 2025
Member
|
Thank you @marin-ma. It works after applying this patch. |
zhouyuan
approved these changes
May 29, 2025
|
|
||
| if (fixedRowSize_.has_value()) { | ||
| rowSize_.resize(inputRows, fixedRowSize_.value() + sizeof(RowSizeType)); | ||
| rowSize_.resize(inputRows, fixedRowSize_.value()); |
Member
There was a problem hiding this comment.
so the real issue is due to rowSize is resized 4 more rows?
Contributor
Author
There was a problem hiding this comment.
rowSize_ was wrong for fixed-widths input. It was over calculated by 4 bytes.
marin-ma
added a commit
to marin-ma/gluten
that referenced
this pull request
Jul 16, 2025
warrenzhu25
pushed a commit
to warrenzhu25/gluten
that referenced
this pull request
Jan 10, 2026
…uts (apache#9766) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Change-Id: I14a42017e729dc202fa58c46147512fa39e0d299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue reported here