Reuse CreateReleaseDropDownTask from grails-docs-core #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicative code from buildSrc
# Conflicts: # buildSrc/build.gradle
jamesfredley
commented
Jul 23, 2025
jamesfredley
commented
Jul 23, 2025
jamesfredley
commented
Jul 23, 2025
jdaugherty
reviewed
Aug 1, 2025
Contributor
jdaugherty
left a comment
jdaugherty
left a comment
There was a problem hiding this comment.
My only concern is the workflow doesn't have the associated change to pull the tags so the tags won't show in the release workflow generated documentation.
jdaugherty
reviewed
Aug 1, 2025
jdaugherty
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicative code from buildSrc
Update some variables in adoc
Eliminates the need for all the test dependencies and config in buildSrc
This will need to wait until after M5, since it requires apache/grails-core#14929 which was not in grails-core:7.0.0-M5