Update Docs to use Apache Grails Maven Groupid #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi James, are you sure ? (I may be looking in the wrong place though) |
Contributor
Author
|
Updating to remove plugins from groupid based on https://repository.apache.org/content/repositories/snapshots/org/apache/grails/ |
Contributor
|
FYI: This is failing because spring security still needs updated for hte publish move. I'll open a separate PR & merge that fix. |
jdaugherty
force-pushed
the
apache-maven-groupid-docs
branch
from
d205bb5 to
11f9ab3
Compare
sbglasius
requested changes
Aug 12, 2025
Contributor
sbglasius
left a comment
sbglasius
left a comment
There was a problem hiding this comment.
I believe that all Spring Security plugins are now prefixed with grails-
Contributor
|
Looks like this mostly resolves: #1049 The only thing left are the s2 apps / commands |
sbglasius
requested changes
Aug 13, 2025
Contributor
sbglasius
left a comment
sbglasius
left a comment
There was a problem hiding this comment.
Found several grails-spring-security-core that should be replaced with grails-spring-security
| implementation 'org.grails.plugins:cxf:3.1.1' | ||
| // CXF above security. | ||
| implementation 'org.grails.plugins:spring-security-core:{revnumber}' | ||
| implementation 'org.apache.grails:grails-spring-security-core:{revnumber}' |
| [source,gradle,subs="+attributes"] | ||
| ---- | ||
| implementation 'org.grails.plugins:spring-security-core:{revnumber}' | ||
| implementation 'org.apache.grails:grails-spring-security-core:{revnumber}' |
| dependencies { | ||
| // ... other dependencies | ||
| implementation 'org.grails.plugins:spring-security-core:{revnumber}' | ||
| implementation 'org.apache.grails:grails-spring-security-core:{revnumber}' |
| dependencies { | ||
| ... | ||
| compile 'org.grails.plugins:spring-security-core:{project-version}' | ||
| implementation 'org.apache.grails:grails-spring-security-core:{project-version}' |
plugin-ldap/docs/src/docs/usage.adoc
Outdated
| compile ("org.grails.plugins:spring-security-ldap:{version}") { | ||
| exclude group: 'org.grails.plugins', module:'spring-security-core' | ||
| } | ||
| implementation "org.apache.grails:grails-spring-security-core:{version}" |
plugin-oauth2/README.md
Outdated
| ... | ||
| implementation 'org.grails.plugins:spring-security-core:5.2.1' | ||
| implementation 'org.grails.plugins:spring-security-oauth2:3.0.0' | ||
| implementation 'org.apache.grails:grails-spring-security-core:{revnumber}' |
plugin-oauth2/README.md
Outdated
| 2. Add the following plugins as dependency in `build.gradle`: | ||
| * `compileOnly 'org.grails.plugins:spring-security-core:3.+'` | ||
| * `compileOnly 'org.grails.plugins:spring-security-oauth2:1.1.+'` | ||
| * `compileOnly 'org.apache.grails:grails-spring-security-core:{revnumber}'` |
| // ... | ||
| api 'org.grails.plugins:spring-security-core' | ||
| api 'org.grails.plugins:spring-security-oauth2' | ||
| api 'org.apache.grails:grails-spring-security-core:{version}' |
Contributor
|
@jamesfredley I pushed a commit to your branch with the fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.