HDDS-1151. Propagate the tracing id in ScmBlockLocationProtocol#508
Closed
elek wants to merge 2 commits intoapache:trunkfrom
Closed
HDDS-1151. Propagate the tracing id in ScmBlockLocationProtocol#508elek wants to merge 2 commits intoapache:trunkfrom
elek wants to merge 2 commits intoapache:trunkfrom
Conversation
…ributed by Elek, Marton.
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Need to add override keyword for overriding a method in scala 2.12. Author: xiliu <xiliu@linkedin.com> Reviewers: Prateek M <prateekm@apache.org> Closes apache#508 from xinyuiscool/SAMZA-1704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracing propagation is not yet enabled for the ScmBlockLocationProtocol. We can't see the internal calls between OM and SCM. We need to propagate it at least for the allocateBlock call.
See: https://issues.apache.org/jira/browse/HDDS-1151