HDDS-1285. Implement actions need to be taken after chill mode exit w… #612

bharatviswa504 · 2019-03-14T23:56:01Z

…ait time.

hadoop-yetus · 2019-03-26T17:06:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#612 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#612
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-612/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-26T19:47:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 12 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	56	Maven dependency ordering for branch
+1	mvninstall	1068	trunk passed
+1	compile	947	trunk passed
+1	checkstyle	213	trunk passed
+1	mvnsite	75	trunk passed
+1	shadedclient	1029	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	51	trunk passed
+1	javadoc	54	trunk passed
		_ Patch Compile Tests _
0	mvndep	23	Maven dependency ordering for patch
+1	mvninstall	64	the patch passed
+1	compile	878	the patch passed
+1	javac	878	the patch passed
+1	checkstyle	207	the patch passed
+1	mvnsite	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	718	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	52	the patch passed
+1	javadoc	53	the patch passed
		_ Other Tests _
+1	unit	97	server-scm in the patch passed.
+1	unit	604	integration-test in the patch passed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		6296

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-612/4/artifact/out/Dockerfile
GITHUB PR	#612
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 4bbc9fb63d7d 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `82d4772`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-612/4/testReport/
Max. process+thread count	4709 (vs. ulimit of 5500)
modules	C: hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-612/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

bharatviswa504 · 2019-04-09T16:34:18Z

@arp7 @nandakumar131 Rebased the PR with the trunk.

nandakumar131 · 2019-04-11T16:03:57Z

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/chillmode/ChillModeHandler.java

We can execute the pipeline cleanup logic in the chillModeExitThread itself, instead of starting a new one.

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneCluster.java

nandakumar131 · 2019-04-11T16:24:20Z

...st/src/test/java/org/apache/hadoop/hdds/scm/chillmode/TestSCMChillModeWithPipelineRules.java

Unused import.

...st/src/test/java/org/apache/hadoop/hdds/scm/chillmode/TestSCMChillModeWithPipelineRules.java

nandakumar131 · 2019-04-11T16:53:21Z

...st/src/test/java/org/apache/hadoop/hdds/scm/chillmode/TestSCMChillModeWithPipelineRules.java

Here as well, do we need GenericTestUtils.waitFor.

Yes because here scm is restarted without waiting for any datanodes.

...st/src/test/java/org/apache/hadoop/hdds/scm/chillmode/TestSCMChillModeWithPipelineRules.java

bharatviswa504 · 2019-04-11T17:29:12Z

Thank You @nandakumar131 for the review.
I have addressed the review comments.

hadoop-yetus · 2019-04-11T19:19:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 9 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	69	Maven dependency ordering for branch
+1	mvninstall	1034	trunk passed
+1	compile	976	trunk passed
+1	checkstyle	195	trunk passed
+1	mvnsite	124	trunk passed
+1	shadedclient	1048	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	52	trunk passed
+1	javadoc	67	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
+1	mvninstall	69	the patch passed
+1	compile	924	the patch passed
+1	javac	924	the patch passed
+1	checkstyle	180	the patch passed
+1	mvnsite	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	639	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	53	the patch passed
+1	javadoc	52	the patch passed
		_ Other Tests _
+1	unit	115	server-scm in the patch passed.
-1	unit	793	integration-test in the patch failed.
+1	asflicense	38	The patch does not generate ASF License warnings.
		6517

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-612/6/artifact/out/Dockerfile
GITHUB PR	#612
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2a6fe7187095 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `a0468c5`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-612/6/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-612/6/testReport/
Max. process+thread count	4207 (vs. ulimit of 5500)
modules	C: hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-612/6/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

nandakumar131

+1. Please fix the checkstyle issue before merging.

bharatviswa504 · 2019-04-12T16:39:41Z

Thank You @nandakumar131 for the review.
I have fixed the checkstyle issue, will commit this shortly.

…r StreamManager Author: Prateek Maheshwari <pmaheshwari@apache.org> Reviewers: Jagadish Venkatraman <vjagadish1989@gmail.com>, Bharath Kumarasubramanian <bkumaras@linkedin.com> Closes apache#612 from prateekm/stream-manager

…sequent apps to fail with "Timer already cancelled" (apache#612) YARN-11384: NPE in DelegationTokenRenewer causes all subsequent apps to fail with "Timer already cancelled" (apache#7404) Contributed by Cheng Pan. Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org> (cherry picked from commit 9c37baf25bf0e648435a54d195de595b2a577adc) Co-authored-by: Cheng Pan <chengpan@apache.org>

bharatviswa504 force-pushed the HDDS-1285 branch from 5fed175 to bcae900 Compare March 14, 2019 23:59

bharatviswa504 self-assigned this Mar 14, 2019

bharatviswa504 requested review from arp7 and nandakumar131 March 15, 2019 00:00

This comment has been minimized.

Sign in to view

bharatviswa504 added the ozone label Mar 19, 2019

bharatviswa504 force-pushed the HDDS-1285 branch from 9e380cd to c70554f Compare March 26, 2019 18:01

bharatviswa504 force-pushed the HDDS-1285 branch from c70554f to ef1df60 Compare April 9, 2019 16:32

This comment has been minimized.

Sign in to view

nandakumar131 requested changes Apr 11, 2019

View reviewed changes

bharatviswa504 force-pushed the HDDS-1285 branch from ef1df60 to bf184f7 Compare April 11, 2019 17:29

bharatviswa504 requested a review from nandakumar131 April 11, 2019 17:29

nandakumar131 approved these changes Apr 12, 2019

View reviewed changes

bharatviswa504 added 3 commits April 12, 2019 09:33

rebase with trunk

59f425c

fix review comments

7d59f2c

fix check style issues.

eba1b77

bharatviswa504 force-pushed the HDDS-1285 branch from bf184f7 to eba1b77 Compare April 12, 2019 16:39

bharatviswa504 merged commit a458c5b into apache:trunk Apr 12, 2019

HDDS-1285. Implement actions need to be taken after chill mode exit w… #612

HDDS-1285. Implement actions need to be taken after chill mode exit w… #612

Uh oh!

Conversation

bharatviswa504 commented Mar 14, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

hadoop-yetus commented Mar 26, 2019

Uh oh!

hadoop-yetus commented Mar 26, 2019

Uh oh!

bharatviswa504 commented Apr 9, 2019

Uh oh!

This comment has been minimized.

nandakumar131 Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nandakumar131 Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nandakumar131 Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bharatviswa504 commented Apr 11, 2019

Uh oh!

hadoop-yetus commented Apr 11, 2019

Uh oh!

nandakumar131 left a comment

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 commented Apr 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants